chore: panic on nullable top-level struct#3550
Merged
blaginin merged 5 commits intoJun 17, 2025
Merged
Conversation
Signed-off-by: blaginin <dima@spiraldb.com>
blaginin
force-pushed
the
db/assert-on-nullable-struct-write
branch
from
0feb5e6 to
2fc7a3d
Compare
Comment on lines
+45
to
+51
| Some(struct_dtype) => { | ||
| if dtype.nullability() == Nullability::Nullable { | ||
| vortex_panic!( | ||
| "FileStatsAccumulator does not support nullable top-level structs, got: {}. Use Validity::NonNullable", | ||
| dtype | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe add a comment say this is a temporary fix until we support files with top level nullability
blaginin
changed the title
Signed-off-by: blaginin <dima@spiraldb.com>
Signed-off-by: blaginin <dima@spiraldb.com>
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
Signed-off-by: blaginin <dima@spiraldb.com> Co-authored-by: Dmitrii Blaginin <dima@blaginin.me> Signed-off-by: mwlon <m.w.loncaric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.