[ABA-18] test(vortex-layout): repro for FileWriter panic on nullable top-level struct#14
Open
abnobdoss wants to merge 1 commit into
Open
[ABA-18] test(vortex-layout): repro for FileWriter panic on nullable top-level struct#14abnobdoss wants to merge 1 commit into
abnobdoss wants to merge 1 commit into
Conversation
… top-level struct Adds an ignored #[should_panic] unit test in file_stats.rs that directly exercises FileStatsAccumulator::new with a nullable top-level struct DType, pinning the current panic behavior until the FileStatsAccumulator semantics decision is made. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Abanoub Doss <abanoub.doss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[ignore]+#[should_panic]unit test directly insidevortex-layout/src/layouts/file_stats.rsthat callsFileStatsAccumulator::newwith a nullable top-level struct DType.FileStatsAccumulatorshould handle nullable top-level structs."temporarily does not support nullable top-level structs".Linear
Closes ABA-18 · https://linear.app/abanoubdoss/issue/ABA-18
Open question
How should
FileStatsAccumulatortreat nullable top-level structs? Options:VortexError(vortex_bail!) instead of a panic — a safe and minimal fix.Existing upstream context
vortex_panic!atfile_stats.rs:73as a temporary guard pending real support.vortex-filecrate already carries a#[should_panic]test for this (write_nullable_top_level_structinvortex-file/src/tests.rs:1251). This PR adds the equivalent unit-level repro at the site of the panic.🤖 Generated with Claude Code