1136-Modularity and optimizations #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 12, 2021
Closed
altay9
reviewed
May 12, 2021
| private void createMap(int[][] courses) { | ||
|
|
||
| inDegreeMap = new int[numOfCourses + 1]; | ||
| courseChiMap = new LinkedList<>(); |
Collaborator
There was a problem hiding this comment.
We should convert this to:
courseChiMap = new ArrayList<>();
Otherwise, it will take 85ms instead of 8ms.
altay9
reviewed
May 12, 2021
| } | ||
|
|
||
| private void createMap(int n, int[][] relations) { | ||
| courseChiMap = new LinkedList<>(); |
Collaborator
There was a problem hiding this comment.
We should also change this to:
courseChiMap = new ArrayList<>();
Otherwise it will take 80ms instead of 5ms.
altay9
approved these changes
May 12, 2021
Collaborator
altay9
left a comment
altay9
left a comment
There was a problem hiding this comment.
Thanks for refactoring. Quite clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both solutions, I removed unnecessary nested procedures to individual methods, making the code more modular.
I have also replaced the HashMap in the DFS solution with an ArrayList as we had done with the BFS solution.