feat: add multi-controlled gates (MCX, MCZ, MCP, generic Ctrl)#1
Merged
Conversation
Implement ControlledGate interface and controlled gate wrapper with: - Constructors: Controlled(), MCX(), MCZ(), MCP() with singleton returns for well-known cases (CNOT, CCX, CZ, CY) - Optimized statevector kernel using control-bit masking (avoids full 2^N matrix construction), with serial + parallel variants - Barenco recursive decomposition (no ancillas, O(n^2) CX gates) - Builder methods: MCX(), MCZ(), MCP(), Ctrl() - QASM emitter: ctrl(N) @ gate syntax (OpenQASM 3.0) - QASM parser: wire up ctrl @ modifier to gate.Controlled() - Circuit draw: @ for control qubits, inner gate symbol for targets - Density matrix: auto-decompose >2 qubit gates recursively All 29 packages pass, zero regressions.
- Fix gofmt alignment in controlled.go, controlled_test.go, kernel_controlled.go - Fix appendAssign: use make+copy instead of append on parameter slices - Fix prealloc: initialize ops slices with capacity hint
- Add token_test.go: Type.String(), LookupIdent(), keyword consistency, and exhaustive token name coverage - Replace make([]T, 0, 32) with var declaration + nolint comment since the recursive decomposition size is unpredictable and Go's append growth (2x below 256 elements) handles it efficiently
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ceb00d57c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement ControlledGate interface and controlled gate wrapper with:
All 29 packages pass, zero regressions.