Conversation
Add generic pulse package with Port/Frame/Waveform/8 instruction types, immutable Program, fluent Builder, and 5 standard waveform shapes. Add IonQ am-v4 custom pulse envelope types with backend integration. Add Braket OpenPulse QASM emission. IBM/local reject pulse programs; mock accepts them. Update feature matrix.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Two-qubit coupling in pulsesim: - Static ZZ coupling via CouplingMap with diagonal phase kernel - Cross-resonance drives via CRFrameMap with conditioned rotation - Functional options (WithCoupling, WithCRFrames) on pulsesim.New() - Block-stride 2Q kernels matching statevector kernel2q pattern - ZZ applied during Play and Delay; CR detected per-frame OpenPulse QASM parser (pulse/qasmparse): - Hand-written lexer with duration literals and comment support - Recursive descent parser for all 8 pulse instruction types - Complex constant parsing with lexer save/restore backtracking - Built-in waveform resolution (constant, gaussian, drag, gaussian_square) - Custom waveform registration via WithWaveform option - Round-trips with braket serializer format Also wired coupling options through backend/local and added CompileWithConfig to pulse/defcal for CR frame metadata.
- Use tagged switch for token type check (staticcheck QF1003) - Remove unused return value from lexer.advance() (unparam) - Suppress unparam on orderedPair (correct API, callers happen to use 0,1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add generic pulse package with Port/Frame/Waveform/8 instruction types, immutable Program, fluent Builder, and 5 standard waveform shapes. Add Braket OpenPulse QASM emission. IBM/local reject pulse programs; mock accepts them.