feat: add while, for, switch, and if/else classical control flow#22
Merged
feat: add while, for, switch, and if/else classical control flow#22
Conversation
Add structured classical control flow to the circuit IR and all layers of the stack, closing the gap with Qiskit and Q#. IR: ControlFlow struct on Operation with While/For/Switch/IfElse types, nested []Operation bodies, ForRange, and SwitchArg. Added WalkOps/MapOps helpers and MaxControlFlowIterations safety cap. Builder: While(), For(), IfElseBlock(), Switch() methods using sub-builder closure pattern consistent with existing IfBlock(). Simulators: Refactored RunDynamic in both statevector and density matrix to recursive executeOps with executeControlFlow dispatch. QASM: Full OpenQASM 3.0 round-trip — parser handles while, for, switch, and if/else; emitter produces corresponding syntax. Added SWITCH/CASE/DEFAULT tokens. Drawing: ASCII, LaTeX, and SVG renderers display control flow as labeled spanning boxes across qubits. Backends: IonQ, Google, Quantinuum, and Quil emit clear errors on unsupported control flow. IBM/Braket get support via QASM emitter. Compose/Tensor/Inverse updated to recurse into control flow bodies. Transpile passes safely pass through control flow operations.
- Check error return from emitOp in emitOps (errcheck/G104) - Rewrite if-else chains to switch statements (gocritic) - Fix gofmt alignment in ControlFlowType const and test comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add structured classical control flow to the circuit IR and all layers of the stack, closing the gap with Qiskit and Q#.
IR: ControlFlow struct on Operation with While/For/Switch/IfElse types, nested []Operation bodies, ForRange, and SwitchArg. Added WalkOps/MapOps helpers and MaxControlFlowIterations safety cap.
Builder: While(), For(), IfElseBlock(), Switch() methods using sub-builder closure pattern consistent with existing IfBlock().
Simulators: Refactored RunDynamic in both statevector and density matrix to recursive executeOps with executeControlFlow dispatch.
QASM: Full OpenQASM 3.0 round-trip — parser handles while, for, switch, and if/else; emitter produces corresponding syntax. Added SWITCH/CASE/DEFAULT tokens.
Drawing: ASCII, LaTeX, and SVG renderers display control flow as labeled spanning boxes across qubits.
Backends: IonQ, Google, Quantinuum, and Quil emit clear errors on unsupported control flow. IBM/Braket get support via QASM emitter.
Compose/Tensor/Inverse updated to recurse into control flow bodies. Transpile passes safely pass through control flow operations.