refactor: simplify codebase, eliminate duplication, reduce allocations#25
Merged
refactor: simplify codebase, eliminate duplication, reduce allocations#25
Conversation
Owner
splch
commented
Mar 17, 2026
splch
commented
- Make KAK delegate to KAKForBasis, removing ~170 lines of near-duplicate ZYZ-specific functions (kakGeneral, oneCNOTCircuit, twoCNOTCircuit, threeCNOTCircuit, tryLocalDecompose)
- Add runParallel3q helper for 3-qubit kernels, matching the existing runParallel2q pattern and eliminating ~100 lines of boilerplate
- Replace hand-rolled sortInts with slices.Sort
- Fix kernel2qCZ discarding blockStride2 return values then recomputing
- Remove dead assignments across 7 files (_ = iter, _ = cg, _ = detPhase, _ = newDim, _ = round)
- Fix CommuteThroughCNOT calling c.Ops() twice (two defensive copies)
- Remove redundant name variable in expandOpsToIonQ
- Eliminate unnecessary Ops() defensive copies on read-only paths in compose.go, densitymatrix Apply, analysis BuildTimelines, transpile passes, and clifford sim
- Pre-allocate slices outside hot loop in applyControlledGateN
- Hoist c.Ops() above shots loop in clifford simulator
- Make KAK delegate to KAKForBasis, removing ~170 lines of near-duplicate ZYZ-specific functions (kakGeneral, oneCNOTCircuit, twoCNOTCircuit, threeCNOTCircuit, tryLocalDecompose) - Add runParallel3q helper for 3-qubit kernels, matching the existing runParallel2q pattern and eliminating ~100 lines of boilerplate - Replace hand-rolled sortInts with slices.Sort - Fix kernel2qCZ discarding blockStride2 return values then recomputing - Remove dead assignments across 7 files (_ = iter, _ = cg, _ = detPhase, _ = newDim, _ = round) - Fix CommuteThroughCNOT calling c.Ops() twice (two defensive copies) - Remove redundant name variable in expandOpsToIonQ - Eliminate unnecessary Ops() defensive copies on read-only paths in compose.go, densitymatrix Apply, analysis BuildTimelines, transpile passes, and clifford sim - Pre-allocate slices outside hot loop in applyControlledGateN - Hoist c.Ops() above shots loop in clifford simulator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.