Conversation
SVG visualizations overflow on narrow screens because they use fixed pixel width/height without viewBox. Add viewBox to circuit diagrams and viz package SVGs so content scales instead of clipping, and add a global article svg rule to cover containers that lacked responsive styling (e.g. step-output, widget-output).
…delines Replace half adder and full adder ASCII art pre-blocks in chapter 1 with hand-coded inline SVGs using defs/use for reusable gate symbols, g groups for shared attributes, and CSS variables for dark mode. Add accessibility via role="img" and title elements. Add inline SVG diagram guidelines to chapter-prompt.md covering viewBox, defs/use, symbol, grouping, CSS variables, and accessibility.
Redesign full adder circuit diagram with proper spacing calculated from coordinate math: 45-90px routing channels between boxes, no overlapping elements, all wires entering/exiting box left/right edges. Add --color-* CSS variable aliases to gen-pdf.mjs so inline SVGs render correctly in the PDF print context.
Add package.json with playwright and pdf-lib dependencies for PDF generation. Add textbook-pdf make target that builds the textbook and generates the PDF. Fix textbook-clean to also remove generated chapter HTML files. Ignore .DS_Store and generated PDF.
Extract EXTRA_MODULES variable for the 7 separate Go modules and use loops in test-all, lint, and vet instead of duplicated cd lines. Add missing backend/google and backend/rigetti to all targets. Add 8 missing fuzz targets (pulse, pulsesim, ionq, braket). Add configurable FUZZ_TIME variable (default 30s). Add -count=1 to coverage for fresh results. Add section comments and multi-line .PHONY for readability.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 71.32% 71.36% +0.03%
==========================================
Files 165 165
Lines 17544 17544
==========================================
+ Hits 12514 12520 +6
+ Misses 4064 4059 -5
+ Partials 966 965 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.