Skip to content

M13-P2.5: Source-summary policy and path-first UX#76

Merged
shaypal5 merged 1 commit intomainfrom
codex/m13-p2-5-source-summary-ux
May 3, 2026
Merged

M13-P2.5: Source-summary policy and path-first UX#76
shaypal5 merged 1 commit intomainfrom
codex/m13-p2-5-source-summary-ux

Conversation

@shaypal5
Copy link
Copy Markdown
Contributor

@shaypal5 shaypal5 commented May 3, 2026

Planning notation

Summary

Implements the M13-P2.5 source-summary policy and path-first UX slice.

Changes:

  • Make excerpt-mode generated source summaries prefer claim-bearing sections such as Core Claims, Design Implications, Product Experience Notes, and Summary before falling back to a bounded opening excerpt.
  • Keep the configured generated-summary policy deterministic and read-only during ingest while preserving full extracts for copied/external/transformed sources.
  • Render source-summary source sections path-first/source-file-first before canonical source IDs and include the extract policy used for the page.
  • Make human CLI source displays more path-first/source-ref-first for add-source, source lookup/list, source refresh, ingest, wiki suggest/compile, and brief recent-source output.
  • Allow splendor query --source, splendor wiki suggest, and splendor wiki compile to accept source IDs, titles, or readable paths while continuing to persist canonical source IDs.
  • For query/suggest path aliases, exact readable paths now resolve across all known content-addressed source versions for that path until stable logical source identities exist.
  • Clarify generated-state review policy in README, quickstart, schema/product docs, dogfooding guidance, and the Issue Agent experience report: repo scan footgun, value proposition gap, and improvement ideas #70 design response.
  • Advance synchronized planning-state lines to M13-P2.5 with M13-P3.1 as the conservative next release-finalization/hardening sub-slice.

Validation

  • /Users/shaypalachy/.local/bin/uv run pytest (500 passed)
  • /Users/shaypalachy/.local/bin/uv run ruff format --check .
  • /Users/shaypalachy/.local/bin/uv run ruff check .
  • /Users/shaypalachy/.local/bin/uv run splendor lint

Note: uv was not on the shell PATH in this Codex session, so validation used the installed binary at /Users/shaypalachy/.local/bin/uv.

Follow-ups intentionally deferred

  • Stable logical source identities
  • Supersedes/superseded_by source lifecycle semantics
  • Pruning old generated state
  • Full workspace refresh command
  • splendor pr-summary

Refs #70
Refs #72

Copilot AI review requested due to automatic review settings May 3, 2026 18:54
@shaypal5 shaypal5 added AI & Agents type/feature New product or user-facing capability. labels May 3, 2026
@shaypal5 shaypal5 added this to the Milestone 13 milestone May 3, 2026
@shaypal5 shaypal5 added area/cli CLI surface, parsing, command UX, or exit behavior. area/docs README, docs/, or other human-facing guidance. area/planning Planning state, roadmap, or machine-readable plan tracking. area/query Query behavior, retrieval, or filed-answer workflows. status/needs-review Open and ready for review. priority/p1 High priority, should land soon. release/post-mvp Post-MVP or v0.x/v1 follow-on work. labels May 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 80.57554% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/splendor/commands/ingest.py 75.51% 7 Missing and 5 partials ⚠️
src/splendor/commands/source.py 78.78% 6 Missing and 1 partial ⚠️
src/splendor/commands/query.py 66.66% 4 Missing and 2 partials ⚠️
src/splendor/cli.py 90.47% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

This comment has been minimized.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@shaypal5 shaypal5 force-pushed the codex/m13-p2-5-source-summary-ux branch from d3cc0a6 to 50c0be4 Compare May 3, 2026 19:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

pr-agent-context report:

Repository focus:

- Splendor is a local-first, git-native, schema-driven knowledge compiler for code-and-research
  repositories.
- Prioritize correctness, deterministic filesystem contracts, schema integrity, and CLI behavior.
- Flag regressions in repository automation and contributor workflow quality, not just Python code.
- Do not flag the `shaypal5/pr-agent-context/.github/workflows/pr-agent-context.yml@v4`
  reusable workflow reference, or the matching `tool_ref: v4`, as a supply-chain or
  reproducibility finding. This repository intentionally uses the floating stable `v4` major ref
  for `pr-agent-context` so CI and refresh runs track upstream v4 patch releases.

# Pull request 76

No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #76 in repository https://github.com/splendor-dev/splendor. Treat this PR as all clear unless new signals appear.

Run metadata:

Tool ref: v4
Tool version: 4.0.21
Trigger: commit pushed
Workflow run: 25288542342 attempt 1
Comment timestamp: 2026-05-03T19:29:01.395185+00:00
PR head commit: 50c0be491977b838848778dde8199fe1ff6838e3

@shaypal5 shaypal5 merged commit 800ef8d into main May 3, 2026
8 checks passed
@shaypal5 shaypal5 deleted the codex/m13-p2-5-source-summary-ux branch May 3, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI & Agents area/cli CLI surface, parsing, command UX, or exit behavior. area/docs README, docs/, or other human-facing guidance. area/planning Planning state, roadmap, or machine-readable plan tracking. area/query Query behavior, retrieval, or filed-answer workflows. priority/p1 High priority, should land soon. release/post-mvp Post-MVP or v0.x/v1 follow-on work. status/needs-review Open and ready for review. type/feature New product or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants