Skip to content

Fix titleLabel font upgrade for SSDynamicButton after font change…#28

Merged
Grubas7 merged 1 commit intosplinesoft:masterfrom
Grubas7:master
Dec 31, 2015
Merged

Fix titleLabel font upgrade for SSDynamicButton after font change…#28
Grubas7 merged 1 commit intosplinesoft:masterfrom
Grubas7:master

Conversation

@Grubas7
Copy link
Copy Markdown
Contributor

@Grubas7 Grubas7 commented Dec 27, 2015

Fix for issue #27.

@Grubas7 Grubas7 added the bug label Dec 27, 2015
@Grubas7 Grubas7 self-assigned this Dec 27, 2015
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 27, 2015

Current coverage is 96.77%

Merging #28 into master will increase coverage by +1.94% as of 5d9c002

@@            master     #28   diff @@
======================================
  Files           10      10       
  Stmts          329     310    -19
  Branches         0       0       
  Methods                          
======================================
- Hit            312     300    -12
  Partial          0       0       
+ Missed          17      10     -7

Review entire Coverage Diff as of 5d9c002

Powered by Codecov. Updated on successful CI builds.

@Grubas7
Copy link
Copy Markdown
Contributor Author

Grubas7 commented Dec 28, 2015

@jhersh Ready to review if you have time ;)

jhersh
jhersh reviewed Dec 28, 2015
View reviewed changes
Comment thread SSDynamicText/UIView+SSTextSize.h
Copy link
Copy Markdown
Member

@jhersh jhersh Dec 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and ss_defaultBaseSize could be readonly @propertys.

Copy link
Copy Markdown
Contributor Author

@Grubas7 Grubas7 Dec 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add nullability and generics, andI would change this to property in same PR.
Is that OK for you?

Copy link
Copy Markdown
Member

@jhersh jhersh Dec 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Contributor Author

@Grubas7 Grubas7 Dec 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge this PR, and I'll create new PR over a days with generics, nullability, this property and some minors improvements ;)

@jhersh
Copy link
Copy Markdown
Member

jhersh commented Dec 28, 2015

👍

Grubas7 added a commit that referenced this pull request Dec 31, 2015
@Grubas7
Merge pull request #28 from Grubas7/master
635a2ed 
Fix `titleLabel` font upgrade for `SSDynamicButton` after font change…
@Grubas7 Grubas7 merged commit 635a2ed into splinesoft:master Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Grubas7 Grubas7

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Grubas7 @codecov-io @jhersh