Improve region detection logic on object store factory#741
Merged
lizardoluis merged 1 commit intomainfrom Nov 19, 2024
Merged
Conversation
lizardoluis
force-pushed
the
object_store_factory
branch
2 times, most recently
from
8f6b6c6 to
9d1f0a4
Compare
lizardoluis
force-pushed
the
object_store_factory
branch
from
9d1f0a4 to
d78a398
Compare
timwaizenegger
approved these changes
Nov 19, 2024
timwaizenegger
left a comment
timwaizenegger
left a comment
There was a problem hiding this comment.
LGTM, bucket is not relevant for the region detect decision. But the region is. If a region is configured, we should skip region detect.
gruuya
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.