Merged
Conversation
…or PG/MySQL connectors), don't set credentials to None (omit them instead).
…xtracting them from the JSON params in sgr mount (rather than just username/pw).
…es (isn't specific to it)
* Had to install sqlalchemy-snowflake in the engine outside of the standard Python machinery (not required in sgr) * WHERE clauses are pushed down but joins aren't because of Multicorn. Add an escape hatch in the form of a custom `subquery` parameter that turns a remote query to a mounted table.
…he subquery is set, it can have the schema inside of it).
…onversion), remove the CSV FDW from coverage (is tested inside of the engine)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some machinery to support SQLAlchemy connectors via a customized version of the FDW (that allows users to get tables to point to subqueries on the remote database to get around pushdown limitations and syntax constructs / operations that aren't available in PostgreSQL).
As a showcase, ship a Snowflake data source in this PR: