Merged
Conversation
Instead of trying to enumerate all AST notes, check just the statement classes. IMPORT can use `SelectStmt`; SQL can use that + extra DDL and DML.
Set the default port to 6432, print out a more helpful message in case of a port conflict and delete the half-initialized engine so that the user can rerun the command.
mildbyte
added a commit
that referenced
this pull request
Mar 29, 2021
* Snowflake data source improvements:
* Allow passing envvars to set HTTP proxy parameters, fix incorrect query string generation when passing a warehouse (#414, #413)
* Support for authentication using a private key (#418)
* Splitfiles: relax AST restrictions to support all SELECT/INSERT/UPDATE/DELETE statements (#411)
* Change the default installation port to 6432 and handle port conflicts during install (#375)
* Add retry logic to fix registry closing the SSL connection after 30 seconds, close remote connections in some places (#417)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectStmtin IMPORT). Fixessplitgraph.exceptions.UnsupportedSQLErrorwhen using Splitfiles #411