Merged
Conversation
… inferring the dialect). Also add a special `ignore_decode_errors` flag to ignore decoding errors and fall back to UTF-8 if chardet can't detect an encoding.
mildbyte
added a commit
that referenced
this pull request
Apr 14, 2021
* Add customizable fetch size to the Snowflake data source (#434) * Fix issue with changing the engine password (#437) * Data source refactor (#438): * MySQL: parameter `remote_schema` has been renamed to `dbname` * Mongo: parameter `coll` has been renamed to `collection`; `db` to `database` * Table options are now a separate parameter that is passed to the * Introspection now returns a dictionary of tables and proposed table options OR error classes for tables that we weren't able to introspect (allowing for partial failures) * Mounting can now return a list of mount errors (caller can choose to ignore). * CSV data source: allow passing a partially initialized list of table options without a schema, making it introspect just those S3 keys and fill out the missing table options. * Postgres-level notices are now available in the `PsycopgEngine.notices` list after a `run_sql` invocation. * Multicorn: fix bug where server-level FDW options would override table-level FDW options. Full set of changes: [`v0.2.12...v0.2.13`](v0.2.12...v0.2.13)
mildbyte
added a commit
that referenced
this pull request
Apr 14, 2021
* Add customizable fetch size to the Snowflake data source (#434) * Fix issue with changing the engine password (#437) * Data source refactor (#438): * MySQL: parameter `remote_schema` has been renamed to `dbname` * Mongo: parameter `coll` has been renamed to `collection`; `db` to `database` * Table options are now a separate parameter that is passed to the * Introspection now returns a dictionary of tables and proposed table options OR error classes for tables that we weren't able to introspect (allowing for partial failures) * Mounting can now return a list of mount errors (caller can choose to ignore). * CSV data source: allow passing a partially initialized list of table options without a schema, making it introspect just those S3 keys and fill out the missing table options. * Postgres-level notices are now available in the `PsycopgEngine.notices` list after a `run_sql` invocation. * Multicorn: fix bug where server-level FDW options would override table-level FDW options. Full set of changes: [`v0.2.12...v0.2.13`](v0.2.12...v0.2.13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set default dialect to None (otherwise we always use 'excel' when not inferring the dialect). Also add a special
ignore_decode_errorsflag to ignore decoding errors and fall back to UTF-8 if chardet can't detect an encoding.