Fix mount for data source with empty credentials schema#515
Merged
mildbyte merged 1 commit intosplitgraph:masterfrom Aug 5, 2021
naskoro:grisha--fix-hn-mount-empty-credentials-schema
Merged
Fix mount for data source with empty credentials schema#515mildbyte merged 1 commit intosplitgraph:masterfrom naskoro:grisha--fix-hn-mount-empty-credentials-schema
mildbyte merged 1 commit intosplitgraph:masterfrom
naskoro:grisha--fix-hn-mount-empty-credentials-schema
Conversation
Contributor
|
Good catch, thanks! I'll merge this so that CI/typechecks can run on our side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was checking the hn example I got an error
I was thinking about just fixing
HackerNewsDataSourcelike this:But decided to go a little bit further and create a test reproducing error and more general fix.