Skip to content

Add index to object_ids array in splitgraph_meta.tables #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gruuya merged 9 commits into from
Sep 30, 2021
Merged

Add index to object_ids array in splitgraph_meta.tables #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c12e7e
Add index on object_ids array in splitgraph_meta.tables
gruuya Sep 17, 2021
e5969b9
Proper migration naming
gruuya Sep 17, 2021
6dd3b0d
Ensure proper interpolation of psycopg SQL query
gruuya Sep 17, 2021
b675beb
Add public search path to add_images procedure
gruuya Sep 23, 2021
911a31b
Set search path to public for splitgraph_api.delete_repository proc
gruuya Sep 24, 2021
1263fea
Add public schema to search path for splitgraph_api.delete_image proc
gruuya Sep 24, 2021
5c8c090
Remove typo in help docs
gruuya Sep 27, 2021
2f3dbf1
Fix parameter typo in docstring
gruuya Sep 28, 2021
fea5a76
Fix typo in docstring for push command
gruuya Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion splitgraph/commandline/push_pull.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def push_c(
tags,
):
"""
Push images the Splitgraph registry or another engine.
Push images to the Splitgraph registry or another engine.

If an image is not specified (e.g. `sgr push noaa/climate`, this will push all new images.

Expand Down
10 changes: 6 additions & 4 deletions splitgraph/hooks/data_source/fdw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ def init_fdw(
wrapper: str,
server_options: Optional[Mapping[str, Optional[str]]] = None,
user_options: Optional[Mapping[str, str]] = None,
role: Optional[str] = None,
overwrite: bool = True,
) -> None:
"""
Expand All @@ -313,6 +314,7 @@ def init_fdw(
:param wrapper: Name of the foreign data wrapper (must be installed as an extension on the engine)
:param server_options: Dictionary of FDW options
:param user_options: Dictionary of user options
:param role: The name of the role for which the user mapping is created; defaults to public.
:param overwrite: If the server already exists, delete and recreate it.
"""
from psycopg2.sql import SQL, Identifier
Expand All @@ -332,8 +334,8 @@ def init_fdw(
engine.run_sql(create_server)

if user_options:
create_mapping = SQL("CREATE USER MAPPING IF NOT EXISTS FOR PUBLIC SERVER {}").format(
Identifier(server_id)
create_mapping = SQL("CREATE USER MAPPING IF NOT EXISTS FOR {} SERVER {}").format(
SQL("PUBLIC") if role is None else Identifier(role), Identifier(server_id)
)
user_keys, user_vals = zip(*user_options.items())
create_mapping += _format_options(user_keys)
Expand Down Expand Up @@ -528,8 +530,8 @@ class MongoDataSource(ForeignDataWrapperDataSource):
{
"table_name": {
"schema": {"col1": "type1"...},
"options": {"database": <dbname>, "collection": <collection>}
}
"options": {"database": <dbname>, "collection": <collection>}
}
}
```
"""
Expand Down
1 change: 1 addition & 0 deletions splitgraph/resources/splitgraph_meta/splitgraph_meta--0.0.3--0.0.4.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CREATE INDEX idx_table_objects ON splitgraph_meta.tables USING GIN(object_ids);
6 changes: 3 additions & 3 deletions splitgraph/resources/static/splitgraph_api.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ BEGIN
END
$$
LANGUAGE plpgsql
SECURITY DEFINER SET search_path = splitgraph_meta, pg_temp;
SECURITY DEFINER SET search_path = splitgraph_meta, pg_temp, public;

-- Delete image.
-- Note this doesn't delete references to the image, e.g. where
Expand Down Expand Up @@ -334,7 +334,7 @@ BEGIN
END
$$
LANGUAGE plpgsql
SECURITY DEFINER SET search_path = splitgraph_meta, pg_temp;
SECURITY DEFINER SET search_path = splitgraph_meta, pg_temp, public;

-- tag_image (namespace, repository, image_hash, tag)
CREATE OR REPLACE FUNCTION splitgraph_api.tag_image (
Expand Down Expand Up @@ -396,7 +396,7 @@ BEGIN
END
$$
LANGUAGE plpgsql
SECURITY DEFINER SET search_path = splitgraph_meta, pg_temp;
SECURITY DEFINER SET search_path = splitgraph_meta, pg_temp, public;

--
-- OBJECT API
Expand Down