Skip to content

Image schema repr method #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gruuya merged 2 commits into from
May 30, 2022
Merged

Image schema repr method #680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932cc0e
Add a method to return the schema representation of an image in analo…
gruuya May 30, 2022
7016893
Add return type annotation for the new image-to-schema method
gruuya May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions splitgraph/core/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ def __eq__(self, other: object) -> bool:
return NotImplemented
return self.image_hash == other.image_hash and self.repository == other.repository

def to_schema(self) -> str:
"""Schema reference for the given image."""
return self.repository.to_schema() + ":" + self.image_hash

def get_parent_children(self) -> Tuple[Optional[str], List[str]]:
"""Gets the parent and a list of children of a given image."""
parent = self.parent_id
Expand Down Expand Up @@ -117,8 +121,7 @@ def get_table(self, table_name: str) -> Table:
)
if not result:
raise TableNotFoundError(
"Image %s:%s does not have a table %s!"
% (self.repository, self.image_hash, table_name)
"Image %s does not have a table %s!" % (self.to_schema(), table_name)
)
table_schema, objects = result
return Table(
Expand Down Expand Up @@ -212,9 +215,8 @@ def lq_checkout(
continue

logging.debug(
"Mounting %s:%s/%s into %s",
self.repository.to_schema(),
self.image_hash,
"Mounting %s/%s into %s",
self.to_schema(),
table_name,
target_schema,
)
Expand Down