Skip to content

Manager refactor #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanzmauro merged 1 commit into from
Dec 21, 2020
Merged

Manager refactor #179

sanzmauro merged 1 commit into from
Dec 21, 2020

Conversation

@sanzmauro
Copy link
Contributor

@sanzmauro sanzmauro commented Dec 21, 2020

  • removed validations
  • moved creation method to class

@sanzmauro sanzmauro self-assigned this Dec 21, 2020
mredolatti
mredolatti approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@mredolatti mredolatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sanzmauro sanzmauro force-pushed the split-manager-refactor branch from 6a0f20b to 6e4f77e Compare December 21, 2020 13:42
@sonarqube-pull-requests
Copy link

sonarqube-pull-requests bot commented Dec 21, 2020

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

96.4% 96.4% Coverage
0.0% 0.0% Duplication

@sanzmauro sanzmauro merged commit 897eb5d into input-validation-refactor Dec 21, 2020
@sanzmauro sanzmauro deleted the split-manager-refactor branch December 21, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mredolatti mredolatti mredolatti approved these changes

@mmelograno mmelograno Awaiting requested review from mmelograno

Assignees

@sanzmauro sanzmauro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanzmauro @mredolatti