Skip to content

added less than or equal semver matcher #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2024
Merged

added less than or equal semver matcher #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28ef210
polish
May 2, 2024
6fa6faf
Merge branch 'semver-greater-equalto-matcher' into semver-less-equalt…
chillaq May 2, 2024
11a247a
Merge branch 'Feature/Semver' into semver-less-equalto-matcher
chillaq May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/main/java/io/split/engine/matchers/LessThanOrEqualToSemverMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ public LessThanOrEqualToSemverMatcher(String semVer) {

@Override
public boolean match(Object matchValue, String bucketingKey, Map<String, Object> attributes, EvaluationContext evaluationContext) {
if (matchValue == null) {
if (matchValue == null || _semVer == null) {
return false;
}
Semver matchSemver = Semver.build(matchValue.toString());
if (matchSemver == null) {
return false;
}

return _semVer != null && matchSemver.Compare(_semVer) <= 0;
return matchSemver.Compare(_semVer) <= 0;
}

@Override
Expand Down
1 change: 0 additions & 1 deletion client/src/test/java/io/split/engine/matchers/GreaterThanOrEqualToSemverMatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ public class GreaterThanOrEqualToSemverMatcherTest {
@Test
public void works() {
GreaterThanOrEqualToSemverMatcher greaterThanOrEqualToSemverMatcher = new GreaterThanOrEqualToSemverMatcher("2.1.8");

assertTrue( greaterThanOrEqualToSemverMatcher.match("2.1.8", null, null, null));
assertTrue( greaterThanOrEqualToSemverMatcher.match("2.1.9", null, null, null));
assertFalse( greaterThanOrEqualToSemverMatcher.match("2.1.8-rc", null, null, null));
Expand Down
11 changes: 6 additions & 5 deletions client/src/test/java/io/split/engine/matchers/LessThanOrEqualToSemverMatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import org.junit.Test;

import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertFalse;

/**
* Tests for EqualToSemverMatcher
Expand All @@ -14,10 +15,10 @@ public class LessThanOrEqualToSemverMatcherTest {
public void works() {
LessThanOrEqualToSemverMatcher lessThanOrEqualToSemverMatcher = new LessThanOrEqualToSemverMatcher("2.1.8");

assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8", null, null, null) == true);
assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.9", null, null, null) == false);
assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8-rc", null, null, null) == true);
assertTrue( lessThanOrEqualToSemverMatcher.match("2.0.10", null, null, null) == true);
assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8+build", null, null, null) == true);
assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8", null, null, null));
assertFalse( lessThanOrEqualToSemverMatcher.match("2.1.9", null, null, null));
assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8-rc", null, null, null));
assertTrue( lessThanOrEqualToSemverMatcher.match("2.0.10", null, null, null));
assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8+build", null, null, null));
}
}