Extract impressions module #625
Quality Gate failed
Failed conditions
66.8% Coverage on New Code (required ≥ 80%)
Annotations
Check warning on line 103 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
Remove this unnecessary cast to "int".
[S1905] Redundant casts should not be used
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=2a61f0bf-09b0-40f1-bea2-d98885b1b219&open=2a61f0bf-09b0-40f1-bea2-d98885b1b219
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_telemetryRecorder" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=c9d2d67f-f60b-4fec-a628-668f465d0ee2&open=c9d2d67f-f60b-4fec-a628-668f465d0ee2
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_telemetrySynchronizer" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=7311ef74-c4dc-4af6-bb67-7c90679401a3&open=7311ef74-c4dc-4af6-bb67-7c90679401a3
sonarqube-pull-requests / SonarQube Code Analysis
Method has 9 parameters, which is greater than 7 authorized.
[S107] Methods should not have too many parameters
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=1280ffae-19f1-48fb-bcd0-1d998467adf5&open=1280ffae-19f1-48fb-bcd0-1d998467adf5
Check warning on line 185 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
Remove these useless parentheses.
[S1110] Redundant pairs of parentheses should be removed
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=391408e9-2ced-4076-9c56-142f9d9a69c3&open=391408e9-2ced-4076-9c56-142f9d9a69c3
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_counter" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=d070c0e2-6ccc-485d-bb97-6159712061c9&open=d070c0e2-6ccc-485d-bb97-6159712061c9
Check warning on line 144 in client/src/main/java/io/split/client/SplitFactoryImpl.java
sonarqube-pull-requests / SonarQube Code Analysis
Split this “Monster Class” into smaller and more specialized ones to reduce its dependencies on other classes from 32 to the maximum authorized 20 or less.
[S6539] Classes should not depend on an excessive number of classes (aka Monster Class)
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=ee59d0bf-4013-4b6f-b020-fd7900daf6cc&open=ee59d0bf-4013-4b6f-b020-fd7900daf6cc
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_telemetryRecorder" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=bd841e90-6b6d-41e8-b313-7944f23073bb&open=bd841e90-6b6d-41e8-b313-7944f23073bb
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_debugEnabled" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=fbd2f7ad-4105-4a43-9d0e-93fb5450812d&open=fbd2f7ad-4105-4a43-9d0e-93fb5450812d
Check warning on line 20 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
Add a private constructor to hide the implicit public one.
[S1118] Utility classes should not have public constructors
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=cfd90460-42b3-47fe-bfa6-9853998fafc7&open=cfd90460-42b3-47fe-bfa6-9853998fafc7
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_mode" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=f64e8a74-982f-4c50-bee0-e14444a416f9&open=f64e8a74-982f-4c50-bee0-e14444a416f9
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_impressionsRefreshRateSeconds" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=279a3fbe-4aa5-4d74-9594-70660d6c0dd2&open=279a3fbe-4aa5-4d74-9594-70660d6c0dd2
Check failure on line 245 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
Add a default case to this switch.
[S131] "switch" statements should have "default" clauses
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=6846a956-261d-45b2-b90c-89109a669230&open=6846a956-261d-45b2-b90c-89109a669230
Check warning on line 127 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
This block of commented-out lines of code should be removed.
[S125] Sections of code should not be commented out
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=f7902be7-be2e-4ddf-8e2d-d778bf02b5e6&open=f7902be7-be2e-4ddf-8e2d-d778bf02b5e6
sonarqube-pull-requests / SonarQube Code Analysis
Remove this unnecessary import: same package classes are always implicitly imported.
[S1128] Unnecessary imports should be removed
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=e97558e7-1a85-4127-bdea-13ae9efcdea2&open=e97558e7-1a85-4127-bdea-13ae9efcdea2
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_uniqueKeysSender" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S116] Field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=878063f5-f44d-4c90-afec-56412b16383b&open=878063f5-f44d-4c90-afec-56412b16383b
sonarqube-pull-requests / SonarQube Code Analysis
Rename this field "_uniqueKeysSender" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S3008] Static non-final field names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=75452425-f16e-4626-ba8f-150db5d29134&open=75452425-f16e-4626-ba8f-150db5d29134
Check failure on line 265 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
End this switch case with an unconditional break, return or throw statement.
[S128] Switch cases should end with an unconditional "break" statement
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=4f606ee3-583a-4cc8-a08c-b910818366b4&open=4f606ee3-583a-4cc8-a08c-b910818366b4
sonarqube-pull-requests / SonarQube Code Analysis
Method has 9 parameters, which is greater than 7 authorized.
[S107] Methods should not have too many parameters
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=f07e2545-27ed-4a3a-9ada-7a0ec640b073&open=f07e2545-27ed-4a3a-9ada-7a0ec640b073
Check failure on line 246 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
End this switch case with an unconditional break, return or throw statement.
[S128] Switch cases should end with an unconditional "break" statement
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=6acadd52-d05b-4454-a2aa-a83c8d5af9a1&open=6acadd52-d05b-4454-a2aa-a83c8d5af9a1
Check failure on line 277 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
End this switch case with an unconditional break, return or throw statement.
[S128] Switch cases should end with an unconditional "break" statement
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=0ffa9894-0603-410b-8315-64143d117c5a&open=0ffa9894-0603-410b-8315-64143d117c5a
Check warning on line 154 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
This block of commented-out lines of code should be removed.
[S125] Sections of code should not be commented out
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=3b64b841-302c-4738-b0eb-77edc99beab9&open=3b64b841-302c-4738-b0eb-77edc99beab9
sonarqube-pull-requests / SonarQube Code Analysis
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
[S1186] Methods should not be empty
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=bfc67ed3-ebc5-413a-b641-1aa5c0201358&open=bfc67ed3-ebc5-413a-b641-1aa5c0201358
Check warning on line 68 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
[S100] Method names should comply with a naming convention
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=1644851f-c6d8-4f11-8892-57a6b905d029&open=1644851f-c6d8-4f11-8892-57a6b905d029
Check warning on line 106 in impressions/src/main/java/io/split/rules/bucketing/MurmurHash3.java
sonarqube-pull-requests / SonarQube Code Analysis
Remove these useless parentheses.
[S1110] Redundant pairs of parentheses should be removed
See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=625&issues=8f907f2c-8f6a-49e3-99aa-9e19baa13a91&open=8f907f2c-8f6a-49e3-99aa-9e19baa13a91