Synchronizer - e2e Happy path setup#15
Merged
emilianofant-split merged 22 commits intomainfrom Jul 5, 2021
Merged
Conversation
…nfig to run sequentially
EmilianoSanchez
requested changes
Jun 29, 2021
Contributor
EmilianoSanchez
left a comment
EmilianoSanchez
left a comment
There was a problem hiding this comment.
Besides the other comments, check Emi if the file src/__tests__/index.spec.ts can be removed, because it doesn't have any meaningful test.
Same with src/__tests__/customStorage/package.json and src/__tests__/customStorage/package-lock.json that I think they are unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javascript Slim Synchronizer
What did you accomplish?
1 - Created a basic e2e setup to test the "happy path"
2 - Added
json-serverto mock the Split API (from which to obtain Splits and Segments)3 - Added
start-stop-serverto runjson-serverAPI and then run e2e tests4 - Configured
redis-servicein Travis5 - Scripts to support Redis validation
6 - Added RedisCustomWrapper for testing with Redis
7 - Included SDK in Consumer mode to interact with Redis Storage and generate Impressions & Events
How do we test the changes introduced in this PR?
git checkout efant_e2eTests_v2npm i**NOTE: you need to set a Redis server locally at
localhost:6379**npm run test:e2e`Related JIRA tickets and PRs
E2E setup
E2E - Travis setup
Extra Notes