[Synchroniser] - Implement batch size config and retries strategy for Impressions#22
Merged
emilianofant-split merged 3 commits intomainfrom Jul 21, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javascript Slim Synchronizer
What did you accomplish?
In this PR, I'm adding the
a. Retries attempt per request and
b. Impression's Batch size configuration
... to the Impression Synchronizer. (Similar to #19 and #20)
ALSO, I've made some refactor to the
retryfunction to be part of autilsfile, where some helpers function may be placed.How do we test the changes introduced in this PR?
1 - Checkout this branch:
git checkout efant_implementRetryImpressions2 - Run unit tests
npm run test:unitIf you want to test it manually:
This file is a Custom Storage to connect with Redis, and can be used for manual tests.
For example:
Note the path to the Storage file
Related JIRA tickets and PRs
[Synchroniser] - Implement batch size config and retries strategy to Impressions
Extra Notes