Fix/shared memory #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mmelograno merged 5 commits into develop from fix/sharedMemory

Apr 23, 2021

Contributor

mmelograno commented Apr 22, 2021

PHP SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

frazjp65 and others added 5 commits

May 4, 2020 12:00


          Trim cached string before decoding

9e48a95

The `$cached_string` pulled out of the shared memory has trailing chars
that result in the string not being able to be decoded using
`json_decode`. This will never work unless the `$size` is the exact size
of the cached string.  Using `trim` fixes the issue.


          Handle overwriting data

69c32f3

The `shmop_write` function does not clear any existing data. If the
original data was longer than the new data, there will be trialing data
after the new data, causing the cache to be corrupt. Adding a null char
to use to mark then end of the string deals with this. If the new string
is longer, it will overwrite the existing null char.


          Merge pull request #149 from lovullo/bugfix-shmop-decode

6fef326

Trim cached string before decoding


          fixing strings trimm in shared memory

9f25d0f


          Merge branch 'develop' of github.com:splitio/php-client into fix/shar…

85dad13

…edMemory

sonarqube-pull-requests bot commented Apr 22, 2021

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

mredolatti approved these changes

View reviewed changes

mmelograno merged commit 559eea4 into develop

mmelograno deleted the fix/sharedMemory branch

November 23, 2021 18:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet