Skip to content

Task/request dep clen #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmelograno merged 7 commits into from
Mar 16, 2022
Merged

Task/request dep clen #174

mmelograno merged 7 commits into from
Mar 16, 2022

Conversation

@mmelograno
Copy link
Contributor

@mmelograno mmelograno commented Feb 11, 2022

PHP SDK

What did you accomplish?

  • Removed requests dependency.
  • Removed unused logic for HTTP.
  • Updated contributors guide for develop branch.
  • Fixed typo in log.

How do we test the changes introduced in this PR?

Extra Notes

@sonarqube-pull-requests
Copy link

sonarqube-pull-requests bot commented Mar 10, 2022

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mmelograno mmelograno merged commit d72b8a6 into develop Mar 16, 2022
@mmelograno mmelograno deleted the task/requestDepClen branch March 16, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mredolatti mredolatti mredolatti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmelograno @mredolatti