Skip to content
Merged

7.1.1 #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
238053f
removed http logic from repo
Feb 11, 2022
29c0cc1
removed import
Feb 11, 2022
0acf0b2
removed Process component
Feb 11, 2022
1d8e593
updated version for test
Feb 11, 2022
a4cf6cd
added error handling on manager
Feb 11, 2022
09157fe
rollback changes in manager of err handling
Mar 10, 2022
11f4606
added wrapper exception for PHP Redis
Mar 14, 2022
713601b
renamed Wrapper
Mar 14, 2022
215f943
removed commented lines on imports
Mar 14, 2022
6e25937
cleaning SplitCache
Mar 16, 2022
d72b8a6
Merge pull request #174 from splitio/task/requestDepClen
mmelograno Mar 16, 2022
cedc2be
Merge branch 'develop' of github.com:splitio/php-client into task/red…
Mar 16, 2022
98c0a08
cleaned segmentCache
Mar 16, 2022
8690187
cleaned pool
Mar 16, 2022
4cf0a84
added cleaning for key created
Mar 16, 2022
7d75ea5
Merge pull request #176 from splitio/task/cleanSplitCache
mmelograno Mar 16, 2022
d0f73b4
Merge branch 'task/redisWrapper' of github.com:splitio/php-client int…
Mar 16, 2022
97765c1
Merge pull request #177 from splitio/task/cleanSegmentsCache
mmelograno Mar 16, 2022
7ffc5e4
added missing methods
Mar 16, 2022
815673b
Merge pull request #178 from splitio/task/cleanPool
mmelograno Mar 16, 2022
49fed8b
added comments
Mar 16, 2022
24e38e3
prepare release for stage
Mar 16, 2022
9ed72d1
returning Item when an exception occurred
Mar 16, 2022
bd52908
updated tests with changes in redisWrapper
Mar 17, 2022
f85782e
removed commented test
mmelograno Mar 21, 2022
bb602d3
remove Item
mmelograno Mar 21, 2022
c436e33
renamed cache methods
mmelograno Mar 21, 2022
ddcb283
Merge pull request #179 from splitio/task/removeItem
mmelograno Mar 21, 2022
12ddb5c
added .gitattributes to exclude tests
mmelograno Mar 25, 2022
efaf54f
updated changelog
mmelograno Mar 25, 2022
19b1890
Merge pull request #175 from splitio/task/redisWrapper
mmelograno Mar 25, 2022
80e3c93
Merge pull request #180 from splitio/task/gitattributes
mmelograno Mar 25, 2022
0fbcacc
added GHA for updating license year
mmelograno Mar 25, 2022
d85b8d2
Merge pull request #181 from splitio/license-year
mmelograno Mar 25, 2022
995c65c
replaced count(x) == 0 to empty
mmelograno Mar 28, 2022
b7dc0f4
Merge pull request #183 from splitio/task/feedbackChanges
mmelograno Mar 28, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
* text=auto

/doc export-ignore
/tests export-ignore
/.github export-ignore
.gitattributes export-ignore
.gitignore export-ignore
phpunit.xml.dist export-ignore
45 changes: 45 additions & 0 deletions .github/workflows/update-license-year.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Update License Year

on:
schedule:
- cron: "0 3 1 1 *" # 03:00 AM on January 1

permissions:
contents: write
pull-requests: write

jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Set Current year
run: "echo CURRENT=$(date +%Y) >> $GITHUB_ENV"

- name: Set Previous Year
run: "echo PREVIOUS=$(($CURRENT-1)) >> $GITHUB_ENV"

- name: Update LICENSE
uses: jacobtomlinson/gha-find-replace@v2
with:
find: ${{ env.PREVIOUS }}
replace: ${{ env.CURRENT }}
include: "LICENSE"
regex: false

- name: Commit files
run: |
git config user.name 'github-actions[bot]'
git config user.email 'github-actions[bot]@users.noreply.github.com'
git commit -m "Updated License Year" -a

- name: Create Pull Request
uses: peter-evans/create-pull-request@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
title: Update License Year
branch: update-license
7 changes: 7 additions & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
7.1.1 (March 28, 2022)
- Removed unused logic for HTTP and requests dependency.
- Removed all producer logic for Storages.
- Added SafeRedisWrapper for handling exception in Redis.
- Added `.gitattributes` for excluding `tests/.` and other files for composer package.
- Fixed typos in `Splitter.php` and CONTRIBUTORS-GUIDE.

7.1.0 (Dec 3, 2021)
- Added a new option to use when running Redis in cluster mode called `keyHashTags` which receives a list of hashtags from which the SDK will randomly pick one to use on the generated instance.

Expand Down
11 changes: 7 additions & 4 deletions CONTRIBUTORS-GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,29 @@ Split SDK is an open source project and we welcome feedback and contribution. Th

### Development process

1. Fork the repository and create a topic branch from `development` branch. Please use a descriptive name for your branch.
1. Fork the repository and create a topic branch from `develop` branch. Please use a descriptive name for your branch.
2. While developing, use descriptive messages in your commits. Avoid short or meaningless sentences like "fix bug".
3. Make sure to add tests for both positive and negative cases.
4. Run the build script and make sure it runs with no errors.
5. Run all tests and make sure there are no failures.
6. `git push` your changes to GitHub within your topic branch.
7. Open a Pull Request(PR) from your forked repo and into the `development` branch of the original repository.
7. Open a Pull Request(PR) from your forked repo and into the `develop` branch of the original repository.
8. When creating your PR, please fill out all the fields of the PR template, as applicable, for the project.
9. Check for conflicts once the pull request is created to make sure your PR can be merged cleanly into `development`.
9. Check for conflicts once the pull request is created to make sure your PR can be merged cleanly into `develop`.
10. Keep an eye out for any feedback or comments from Split's SDK team.

### Building the SDK

- `composer install`

### Running tests

- `vendor/bin/phpunit -c phpunit.xml.dist --testsuite integration`

### Linting and other useful checks

- `vendor/bin/phpcs --ignore=functions.php --standard=PSR2 src/`

# Contact
## Contact

If you have any other questions or need to contact us directly in a private manner send us a note at sdks@split.io
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright © 2021 Split Software, Inc.
Copyright © 2022 Split Software, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"php": ">=7.3",
"psr/log": "~1.0",
"predis/predis": "^1.1.9",
"rmccue/requests": "^1.8.1",
"symfony/yaml": ">=5.3"
},

Expand Down
32 changes: 20 additions & 12 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -5,53 +5,61 @@
<php>
<const name="REDIS_HOST" value="localhost"/>
<const name="REDIS_PORT" value="6379"/>
<const name="TEST_PREFIX" value="SPLITIO_TEST:."/>
</php>

<testsuites>
<testsuite name="splitio">
<directory suffix="Test.php">tests/</directory>
</testsuite>
<testsuite name="redis-adapter">
<file>tests/Suite/Redis/CacheInterfacesTest.php</file>
<testsuite name="adapter">
<directory suffix="Test.php">tests/Suite/Adapter</directory>
</testsuite>
<testsuite name="attributes">
<directory suffix="Test.php">tests/Suite/Attributes/</directory>
</testsuite>
<testsuite name="common">
<directory suffix="Test.php">tests/Suite/Common/</directory>
</testsuite>
<testsuite name="component">
<directory suffix="Test.php">tests/Suite/Component/</directory>
</testsuite>
<testsuite name="dynamic_configurations">
<directory suffix="Test.php">tests/Suite/DynamicConfigurations/</directory>
</testsuite>
<testsuite name="engine">
<directory suffix="Test.php">tests/Suite/Engine/</directory>
</testsuite>
<testsuite name="input_validation">
<directory suffix="Test.php">tests/Suite/InputValidation/</directory>
</testsuite>
<testsuite name="matchers">
<directory suffix="Test.php">tests/Suite/Matchers/</directory>
</testsuite>
<testsuite name="metrics">
<directory suffix="Test.php">tests/Suite/Metrics/</directory>
</testsuite>
<testsuite name="redis">
<directory suffix="Test.php">tests/Suite/Redis/</directory>
</testsuite>
<testsuite name="sdk">
<directory suffix="Test.php">tests/Suite/Sdk/</directory>
</testsuite>
<testsuite name="attributes">
<directory suffix="Test.php">tests/Suite/Attributes/</directory>
</testsuite>
<testsuite name="input_validation">
<directory suffix="Test.php">tests/Suite/InputValidation/</directory>
</testsuite>



<testsuite name="integration">
<directory suffix="Test.php">tests/Suite/Adapter/</directory>
<directory suffix="Test.php">tests/Suite/Attributes/</directory>
<directory suffix="Test.php">tests/Suite/Common/</directory>
<directory suffix="Test.php">tests/Suite/Component/</directory>
<directory suffix="Test.php">tests/Suite/DynamicConfigurations/</directory>
<directory suffix="Test.php">tests/Suite/Engine/</directory>
<directory suffix="Test.php">tests/Suite/InputValidation/</directory>
<directory suffix="Test.php">tests/Suite/Matchers/</directory>
<directory suffix="Test.php">tests/Suite/Metrics/</directory>
<directory suffix="Test.php">tests/Suite/Redis/</directory>
<directory suffix="Test.php">tests/Suite/Sdk/</directory>
<directory suffix="Test.php">tests/Suite/Adapter/</directory>
<directory suffix="Test.php">tests/Suite/Attributes/</directory>
<directory suffix="Test.php">tests/Suite/InputValidation/</directory>
<directory suffix="Test.php">tests/Suite/DynamicConfigurations/</directory>
</testsuite>
</testsuites>

Expand Down
174 changes: 0 additions & 174 deletions src/SplitIO/Component/Cache/Item.php

This file was deleted.

Loading