Skip to content

Conversation

@mmelograno
Copy link
Contributor

Python SDK

What did you accomplish?

  • Added Recorder Interface: StandardRecorder for recording in memory stats and PipelinedRecorder to perform pipelined operation into redis.
  • Refactored ImpressionManager to decorate impressions.

How do we test the changes introduced in this PR?

Extra Notes

Copy link
Contributor

@mredolatti mredolatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@sonarqube-pull-requests
Copy link

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.4% 88.4% Coverage
0.0% 0.0% Duplication

@sonarqube-pull-requests
Copy link

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

87.3% 87.3% Coverage
0.0% 0.0% Duplication

@sonarqube-pull-requests
Copy link

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

87.3% 87.3% Coverage
0.0% 0.0% Duplication

@mmelograno mmelograno merged commit 31b9107 into development Jan 6, 2021
@mmelograno mmelograno deleted the feature/pipeline branch December 16, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants