update runtime dependencies, peer dependencies#115
Merged
EmilianoSanchez merged 2 commits intosplitio:developmentfrom Dec 16, 2022
Merged
update runtime dependencies, peer dependencies#115EmilianoSanchez merged 2 commits intosplitio:developmentfrom
EmilianoSanchez merged 2 commits intosplitio:developmentfrom
Conversation
- according to https://github.com/splitio/react-client/blob/1a58f06b91c63cac2f4032fa3c338573fb30a615/src/utils.ts#L2 '@splitsoftware/splitio' is a runtime dependency - react peer dependency rules should have a sibling rule for react-dom as well
|
Hi @lfender6445 , thanks for the contribution! Our engineering team will review this and take it into consideration for a future release. |
EmilianoSanchez
approved these changes
Dec 16, 2022
Contributor
|
Hi @lfender6445 , We have merged your changes, but will do some refactors before releasing a new version of the SDK. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React SDK
What did you accomplish?
react-client/src/utils.ts
Line 2 in 1a58f06
npm prune --productionHow do we test the changes introduced in this PR?
Unfortunately I had trouble getting the test suite to pass. I fixed one broken path, but there are 3 more failures, all unrelated I think. Given there have been no logical changes, happy path testing should be fine.
Extra Notes