AUT-1705: Adding SonarQube for react-client.#118
Merged
EmilianoSanchez merged 5 commits intodevelopmentfrom Dec 16, 2022
Merged
AUT-1705: Adding SonarQube for react-client.#118EmilianoSanchez merged 5 commits intodevelopmentfrom
EmilianoSanchez merged 5 commits intodevelopmentfrom
Conversation
melinaurruchua
requested changes
Dec 15, 2022
melinaurruchua
previously approved these changes
Dec 15, 2022
|
SonarQube Quality Gate |
The base branch was changed.
EmilianoSanchez
previously approved these changes
Dec 16, 2022
EmilianoSanchez
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








React SDK
What did you accomplish?
Adding SonarQube step to CI in order have a check for code quality
Since main and development are two permanent branches, we are having two executions in order to make sonar to know about the parent branch.
How do we test the changes introduced in this PR?
Testing from this PR if the step is being executed and giving the right output.
From SonarQube site this PR is being analyzed and showing code coverage.

https://sonarqube.split-internal.com/dashboard?id=react-client&pullRequest=118
Enabled decoration for PR:

Extra Notes
Node version using lts/* was bringing node 18, so that caused problems to build. I updated it to 16.16.0 which was working. I did that since I checked from previous successful builds where lts/* was pulling node 16.16.0.
In order to get the blame information to SonarQube, we told GitHubActions to clone the entire history. This was done on this section:
From SonarQube site I applied the following changes:
Set master & development branches as active branches.
Enabled PullRequest decoration