Release v1.8.1

.github/workflows/ci-cd.yml

@@ -8,6 +8,10 @@ on:
     branches:
       - '*'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'push' && github.run_number || github.event.pull_request.number }}
+  cancel-in-progress: true
+
 permissions:
   contents: read
   id-token: write
@@ -18,54 +22,151 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
 
       - name: Set up nodejs
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
-          node-version: 'lts/*'
+          node-version: '16.16.0'
           cache: 'npm'
 
-      - name: npm CI
+      - name: npm ci
         run: npm ci
 
-      - name: npm Check
+      - name: npm check
         run: npm run check
 
-      - name: npm Test
-        run: npm run build && npm run test # tests require build to use JS SDK in localhost mode
+      - name: npm test
+        run: npm run test -- --coverage
 
-      - name: npm Build
+      - name: npm build
         run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
 
-      - name: Configure AWS credentials (development)
-        if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/development' }}
-        uses: aws-actions/configure-aws-credentials@v1
+      - name: Store assets
+        if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/master') }}
+        uses: actions/upload-artifact@v3
         with:
-          role-to-assume: arn:aws:iam::079419646996:role/public-assets
+          name: assets
+          path: umd/
+          retention-days: 1
+
+  upload-stage:
+    name: Upload assets
+    runs-on: ubuntu-latest
+    needs: build
+    if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/development' }}
+    strategy:
+      matrix:
+        environment:
+          - stage
+          - stage-eu
+        include:
+          - environment: stage
+            account_id: "079419646996"
+            bucket: split-public-stage
+          - environment: stage-eu
+            account_id: "901851837056"
+            bucket: split-public-stage-eu-west-1
+
+    steps:
+      - name: Download assets
+        uses: actions/download-artifact@v3
+        with:
+          name: assets
+          path: umd
+
+      - name: Display structure of assets
+        run: ls -R
+        working-directory: umd
+
+      - name: Configure AWS credentials
+        uses: aws-actions/configure-aws-credentials@v1-node16
+        with:
+          role-to-assume: arn:aws:iam::${{ matrix.account_id }}:role/gha-public-assets-role
           aws-region: us-east-1
 
-      - name: Upload to S3 (development)
-        if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/development' }}
+      - name: Upload to S3
         run: aws s3 sync $SOURCE_DIR s3://$BUCKET/$DEST_DIR $ARGS
         env:
-          BUCKET: split-public-stage
+          BUCKET: ${{ matrix.bucket }}
           SOURCE_DIR: ./umd
           DEST_DIR: sdk
           ARGS: --acl public-read --follow-symlinks --cache-control max-age=31536000,public
 
-      - name: Configure AWS credentials (master)
-        if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
-        uses: aws-actions/configure-aws-credentials@v1
+  upload-prod:
+    name: Upload assets
+    runs-on: ubuntu-latest
+    needs: build
+    if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
+    strategy:
+      matrix:
+        environment:
+          - prod
+          - prod-eu
+        include:
+          - environment: prod
+            account_id: "825951051969"
+            bucket: split-public
+          - environment: prod-eu
+            account_id: "842946900133"
+            bucket: split-public-eu-west-1
+
+    steps:
+      - name: Download assets
+        uses: actions/download-artifact@v3
+        with:
+          name: assets
+          path: umd
+
+      - name: Display structure of assets
+        run: ls -R
+        working-directory: umd
+
+      - name: Configure AWS credentials
+        uses: aws-actions/configure-aws-credentials@v1-node16
         with:
-          role-to-assume: arn:aws:iam::825951051969:role/public-assets
+          role-to-assume: arn:aws:iam::${{ matrix.account_id }}:role/gha-public-assets-role
           aws-region: us-east-1
 
-      - name: Upload to S3 (master)
-        if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
+      - name: Upload to S3
         run: aws s3 sync $SOURCE_DIR s3://$BUCKET/$DEST_DIR $ARGS
         env:
-          BUCKET: split-public
+          BUCKET: ${{ matrix.bucket }}
           SOURCE_DIR: ./umd
           DEST_DIR: sdk
           ARGS: --acl public-read --follow-symlinks --cache-control max-age=31536000,public
+
+      - name: SonarQube Scan (Push)
+        if: github.event_name == 'push'
+        uses: SonarSource/sonarcloud-github-action@v1.8
+        env:
+          SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
+        with:
+          projectBaseDir: .
+          args: >
+            -Dsonar.host.url=${{ secrets.SONARQUBE_HOST }}
+            -Dsonar.projectName=${{ github.event.repository.name }}
+            -Dsonar.projectKey=${{ github.event.repository.name }}
+            -Dsonar.javascript.lcov.reportPaths=./coverage/lcov.info
+            -Dsonar.links.ci="https://github.com/splitio/${{ github.event.repository.name }}/actions"
+            -Dsonar.links.scm="https://github.com/splitio/${{ github.event.repository.name }}"
+
+      - name: SonarQube Scan (Pull Request)
+        if: github.event_name == 'pull_request'
+        uses: SonarSource/sonarcloud-github-action@v1.8
+        env:
+          SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
+        with:
+          projectBaseDir: .
+          args: >
+            -Dsonar.host.url=${{ secrets.SONARQUBE_HOST }}
+            -Dsonar.projectName=${{ github.event.repository.name }}
+            -Dsonar.projectKey=${{ github.event.repository.name }}
+            -Dsonar.links.ci="https://github.com/splitio/${{ github.event.repository.name }}/actions"
+            -Dsonar.links.scm="https://github.com/splitio/${{ github.event.repository.name }}"
+            -Dsonar.javascript.lcov.reportPaths=./coverage/lcov.info
+            -Dsonar.pullrequest.key=${{ github.event.pull_request.number }}
+            -Dsonar.pullrequest.branch=${{ github.event.pull_request.head.ref }}
+            -Dsonar.pullrequest.base=${{ github.event.pull_request.base.ref }}

.nvmrc

@@ -1 +1 @@
-v14
+v16.16.0

CHANGES.txt

@@ -1,3 +1,7 @@
+1.8.1 (December 16, 2022)
+ - Updated some transitive dependencies for vulnerability fixes.
+ - Bugfixing - Upgrade @splitsoftware/splitio dependency to version 10.22.3 which includes a memory leak fix for localhost mode (Related to issue https://github.com/splitio/javascript-commons/issues/181) among other improvements.
+
 1.8.0 (October 5, 2022)
  - Updated @splitsoftware/splitio dependency to version 10.22.0, which includes:
       - Added a new impressions mode for the SDK called NONE, to be used in factory when there is no desire to capture impressions on an SDK factory to feed Split's analytics engine. Running NONE mode, the SDK will only capture unique keys evaluated for a particular feature flag instead of full blown impressions.