Skip to content

fix rbs repository #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix rbs repository #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4aeda4
fix rbs repository
chillaq Jul 23, 2025
db90929
added test
chillaq Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/splitclient-rb/cache/repositories/rule_based_segments_repository.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ def clear

def contains?(segment_names)
return false if rule_based_segment_names.empty?
return set(segment_names).subset?(rule_based_segment_names)

return segment_names.to_set.subset?(rule_based_segment_names.to_set)
end

private
Expand Down
5 changes: 5 additions & 0 deletions spec/cache/repositories/rule_based_segments_repository_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
)
end

it 'contains' do
expect(repository.contains?(['foo', 'bar'].to_set)).to eq(true)
expect(repository.contains?(['foo', 'oof'].to_set)).to eq(false)
end

it 'remove undefined matcher with template condition' do
rule_based_segment = { name: 'corge', trafficTypeName: 'tt_name_5', conditions: [
{
Expand Down