Skip to content

Add ECR #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariano-arago merged 1 commit into from
Jul 8, 2025
Merged

Add ECR #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 22 additions & 37 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@ name: docker
on:
push:
branches:
- master
- main
pull_request:
branches:
- master
- main

concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'push' && github.run_number || github.event.pull_request.number }}
cancel-in-progress: true

permissions:
contents: read
id-token: write

jobs:
docker:
name: Build Docker image
Expand All @@ -28,32 +32,22 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to Artifactory
if: ${{ github.event_name == 'push' }}
- name: Login to Dockerhub
uses: docker/login-action@v3
with:
registry: splitio-docker-dev.jfrog.io
username: ${{ secrets.ARTIFACTORY_DOCKER_USER }}
password: ${{ secrets.ARTIFACTORY_DOCKER_PASS }}

- name: Create build version
run: echo "BUILD_VERSION=$(cat package.json | grep version | head -1 | awk '{ print $2 }' | sed 's/[\",]//g' | tr -d '[[:space:]]')" >> $GITHUB_ENV
username: ${{ vars.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_RO_TOKEN }}

- name: Docker build
uses: docker/build-push-action@v6
- name: Configure AWS credentials
if: ${{ github.event_name == 'push' }}
uses: aws-actions/configure-aws-credentials@v4
with:
context: .
push: ${{ github.event_name == 'push' }}
platforms: linux/amd64,linux/arm64
tags: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:${{ env.BUILD_VERSION}},splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:latest
role-to-assume: ${{ vars.ECR_TESTING_ROLE_ARN }}
aws-region: us-east-1

lacework:
name: Scan Docker image
if: ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Login to Amazon ECR
if: ${{ github.event_name == 'push' }}
uses: aws-actions/amazon-ecr-login@v2

- name: Create build version
run: echo "BUILD_VERSION=$(cat package.json | grep version | head -1 | awk '{ print $2 }' | sed 's/[\",]//g' | tr -d '[[:space:]]')" >> $GITHUB_ENV
Expand All @@ -62,17 +56,8 @@ jobs:
uses: docker/build-push-action@v6
with:
context: .
push: false
tags: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:${{ env.BUILD_VERSION}}
build-args: |
ARTIFACTORY_USER=${{ secrets.ARTIFACTORY_USER }}
ARTIFACTORY_TOKEN=${{ secrets.ARTIFACTORY_TOKEN }}

- name: Scan container using Lacework
uses: lacework/lw-scanner-action@v1.4.5
with:
LW_ACCOUNT_NAME: ${{ secrets.LW_ACCOUNT_NAME }}
LW_ACCESS_TOKEN: ${{ secrets.LW_ACCESS_TOKEN }}
IMAGE_NAME: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}
IMAGE_TAG: ${{ env.BUILD_VERSION}}
SAVE_RESULTS_IN_LACEWORK: true
push: ${{ github.event_name == 'push' }}
platforms: linux/amd64,linux/arm64
tags: |
${{ vars.ECR_TESTING_URL }}/${{ github.event.repository.name }}:${{ env.BUILD_VERSION }}
${{ vars.ECR_TESTING_URL }}/${{ github.event.repository.name }}:latest
27 changes: 21 additions & 6 deletions .github/workflows/unstable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,33 @@ name: unstable
on:
push:
branches-ignore:
- master
- main

permissions:
contents: read
id-token: write

jobs:
push-docker-image:
name: Build and Push Docker Image
runs-on: ubuntu-latest
steps:
- name: Login to DockerHub
- name: Login to Dockerhub
uses: docker/login-action@v3
with:
registry: splitio-docker-dev.jfrog.io
username: ${{ secrets.ARTIFACTORY_DOCKER_USER }}
password: ${{ secrets.ARTIFACTORY_DOCKER_PASS }}
username: ${{ vars.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_RO_TOKEN }}

- name: Configure AWS credentials
if: ${{ github.event_name == 'push' }}
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.ECR_TESTING_ROLE_ARN }}
aws-region: us-east-1

- name: Login to Amazon ECR
if: ${{ github.event_name == 'push' }}
uses: aws-actions/amazon-ecr-login@v2

- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -37,4 +51,5 @@ jobs:
context: .
push: true
platforms: linux/amd64,linux/arm64
tags: splitio-docker-dev.jfrog.io/${{ github.event.repository.name }}:${{ env.SHORT_SHA}}
tags: |
${{ vars.ECR_TESTING_URL }}/${{ github.event.repository.name }}:${{ env.SHORT_SHA }}