Rescue from Redis::BaseError in #ab_test #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis defines a number of different exception classes (see https://github.com/redis/redis-rb/blob/1bd43346cdf71ba69176612714616289a5a70ed4/lib/redis/errors.rb for details). When Redis raises an exception, we need to be able to have the db_failover configuration used, whether it's a failure to connect, a timeout, or an invalid command. We ran into this issue when our Redis instance ran out of memory. In that case (and most others), Split should be able to handle things gracefully.
|
Thanks @nfm, I'll get a new release out later today. |
andrew
added a commit
that referenced
this pull request
Oct 20, 2015
Rescue from Redis::BaseError in #ab_test
|
Thanks for the quick release @andrew 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis defines a number of different exception classes (see https://github.com/redis/redis-rb/blob/1bd43346cdf71ba69176612714616289a5a70ed4/lib/redis/errors.rb for details). When Redis raises an exception, we need to be able to have the db_failover configuration used, whether it's a failure to connect, a timeout, or an invalid command.
We ran into this issue when our Redis instance ran out of memory. In that case (and most others), Split should be able to handle things gracefully.