Introduce goals collection to reduce complexity of Experiment#save #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful for debugging.
|
Thanks for the refactor @pakallis, would you be able to add some tests for the |
|
Sure, i'm on it |
Towards a more object-oriented approach, i introduced the GoalsCollection class and refactored the code so that the overall complexity of Experiment#save is reduced.
| s.add_development_dependency 'rack-test', '~> 0.6' | ||
| s.add_development_dependency 'rake', '~> 11.1' | ||
| s.add_development_dependency 'rspec', '~> 3.4' | ||
| s.add_development_dependency 'pry' |
There was a problem hiding this comment.
I also added pry gem for easier debugging
There was a problem hiding this comment.
Can you add a broad version range here for pry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.