Skip to content

Use Experiment#set_alternatives_and_options to DRY code #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2016
Merged

Use Experiment#set_alternatives_and_options to DRY code #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions lib/split/experiment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ def extract_alternatives_from_options(options)
end
end

self.alternatives = alts
self.goals = options[:goals]
self.algorithm = options[:algorithm]
self.resettable = options[:resettable]
options[:alternatives] = alts

set_alternatives_and_options(options)

# calculate probability that each alternative is the winner
@alternative_probabilities = {}
Expand Down Expand Up @@ -267,11 +266,16 @@ def delete_metadata

def load_from_redis
exp_config = Split.redis.hgetall(experiment_config_key)
self.resettable = exp_config['resettable']
self.algorithm = exp_config['algorithm']
self.alternatives = load_alternatives_from_redis
self.goals = Split::GoalsCollection.new(@name).load_from_redis
self.metadata = load_metadata_from_redis

options = {
resettable: exp_config['resettable'],
algorithm: exp_config['algorithm'],
alternatives: load_alternatives_from_redis,
goals: Split::GoalsCollection.new(@name).load_from_redis,
metadata: load_metadata_from_redis
}

set_alternatives_and_options(options)
end

def calc_winning_alternatives
Expand Down