Skip to content

Eliminate extra RedisAdapter hget #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Eliminate extra RedisAdapter hget #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/split/trial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,18 @@ def choose!(context = nil)

if exclude_user?
self.alternative = @experiment.control
elsif @user[@experiment.key]
self.alternative = @user[@experiment.key]
else
self.alternative = @experiment.next_alternative
value = @user[@experiment.key]
if value
self.alternative = value
else
self.alternative = @experiment.next_alternative

# Increment the number of participants since we are actually choosing a new alternative
self.alternative.increment_participation
# Increment the number of participants since we are actually choosing a new alternative
self.alternative.increment_participation

run_callback context, Split.configuration.on_trial_choose
run_callback context, Split.configuration.on_trial_choose
end
end
end

Expand Down