Skip to content

Conversation

@daviddening
Copy link
Contributor

This pull requests proposes allowing users to create combined experiments, so they can see how one change affects multiple behaviors (ie does changing the button size increase its clickability at the expense of overall clicks) Its inspired by something I hacked together for my own tests.

I'm looking for feedback on 1) whether this is something desired for the gem 2) if so, I think it could be integrated into the ab_test method OR should be in its own helper.

@daviddening daviddening force-pushed the feature/combined-tests branch from 58e9f14 to 075aadd Compare July 3, 2017 13:38
@andrew
Copy link
Member

andrew commented Jul 3, 2017

Thanks @daviddening, it's been a long while since I really thought about the internals of this project but that seems like a useful feature, did you see any existing issues that are related to it?

I'd err on the side of putting it in it's own helper method rather than overloading ab_test.

Also all of the raise calls in a row feel a bit nasty, perhaps some of them could be pulled out into a single check method?

@daviddening daviddening force-pushed the feature/combined-tests branch from 02737e2 to 2535e65 Compare July 3, 2017 15:47
@daviddening
Copy link
Contributor Author

@andrew Thanks! I did a quick refactor to bring the pull request in line with the suggestions.

This issue #275 seems closely related to the feature I built. I have also seen this feature requested on the StackOverflow.

I feel like I should add few more README updates as well, which I'll try to push up sometime tomorrow.

@daviddening
Copy link
Contributor Author

@andrew Any further comments or thoughts on this?

@andrew andrew merged commit ccff6dc into splitrb:master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants