Use RSpec fuzzy value matching for hash comparison#156
Conversation
Collaborator
Author
|
I believe the collection including operator tree builder has the same issue, but I'm not sure how to replace Diff::LCS's comparison operator with fuzzy matching. |
mcmire
reviewed
Jul 18, 2022
mcmire
approved these changes
Sep 1, 2022
Collaborator
|
Hi @jas14, thanks for the ping and sorry it took so long for me to merge this. Thanks for this PR, seems like a great solution! |
|
Oh wow so much simpler than I expected, thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋 I believe this fixes #150.
The issue seems to be that RSpec uses fuzzy matching to compare hashes in the "include" matcher, while super_diff's current RSpec-specific HashIncluding operation tree builder uses exact equality.
I understand this likely degrades performance, but maybe it's worth it to make the diff line up with RSpec's matching logic.
Eagerly awaiting your feedback!