changing ordering of test cases and fixing failures #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilgajera-crest
requested review from
jayjoshi-crest,
nariyanibhargav,
ryanfaircloth and
siddharth-khatsuriya
siddharth-khatsuriya
approved these changes
Sep 2, 2020
jayjoshi-crest
approved these changes
Sep 2, 2020
ryanfaircloth
approved these changes
Sep 2, 2020
nariyanibhargav
approved these changes
Sep 2, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changed ordering of test cases as test_acl was dependent on test__kvstore because test__kvstore was generating a collection which was further used by test_acl
Updated static time value from +0800 TZ to UTC to test time-parser, as the the local time of machine is UTC
Updated test_metadata.py to compare strings(type of object) as earlier it was comparing unicode with string