tests template folder missing

[m0n3yspider]

contentctl init does not produce the tests folder which causes errors when running contentctl new -t detection

[0xC0FFEEEE]

It looks like this is caused by some test/debugging code left in output/new_content_yml_output.py. If you comment out lines 17-38 the detection content will be successfully created under the detections directory.

writeObjectNewContent defines test_obj dict on lines 17-36, a file_path_test path on line 37 and finally a call to YmlWriter.writeYmlFile(file_path_test, test_obj) on line 38. This causes contentctl to error just before the second call to YmlWriter, as the tests directory does not exist.

def writeObjectNewContent(self, object: dict, type: SecurityContentType) -> None:
    if type == SecurityContentType.detections:
        file_path = os.path.join(self.output_path, 'detections', self.convertNameToFileName(object['name'], object['tags']['product']))
        test_obj = {}
        test_obj['name'] = object['name'] + ' Unit Test'
        test_obj['tests'] = [
            {
                'name': object['name'],
                'file': self.convertNameToFileName(object['name'],object['tags']['product']),
                'pass_condition': '| stats count | where count > 0',
                'earliest_time': '-24h',
                'latest_time': 'now',
                'attack_data': [
                    {
                        'file_name': 'UPDATE',
                        'data': 'UPDATE',
                        'source': 'UPDATE',
                        'sourcetype': 'UPDATE',
                        'update_timestamp': True
                    }
                ]
            }
        ]
        file_path_test = os.path.join(self.output_path, 'tests', self.convertNameToTestFileName(object['name'], object['tags']['product']))
        YmlWriter.writeYmlFile(file_path_test, test_obj)
        #object.pop('source')
        YmlWriter.writeYmlFile(file_path, object)
        print("Successfully created detection " + file_path)

[pyth0n1c]

Great news! Thank you for reporting the issue and submitting the initial fix.
We have fixed this and improved functionality even more in the following PR and released to pip the fix in version 3.0.1 of contentctl :)
#96

Please see the following release, which contains the fix:
https://github.com/splunk/contentctl/releases/tag/v3.0.1