Bugfix/buildstage windows patch#12
Merged
Merged
Conversation
… Chrome/Edge install with pipe transport instead of bundled Chromium over WebSocket. Changes src/utils/resolveBrowserExecutable.js (new) resolveBrowserExecutable() scans platform-specific Chrome/Edge paths and returns the first existing executable. getPuppeteerLaunchOptions() always sets headless mode and sandbox/GPU args. On win32: requires a system browser, sets pipe: true, protocolTimeout: 180_000, and throws a clear error if none is found. On macOS/Linux: uses system Chrome when present, otherwise falls back to bundled Chromium (no pipe). src/utils/renderPdf.js Uses getPuppeteerLaunchOptions() instead of inline launch config. tests/utils/resolveBrowserExecutable.test.js (new) Six unit tests with mocked fs.existsSync and process.platform. Verification npm test — 35 tests passed node bin/md2cd.js tests/fixtures/theme-system — exit 0; PDF written to tests/fixtures/theme-system/dist/themes-course-course-description.pdf (~102 KB) On Windows, users must have Google Chrome or Microsoft Edge installed; otherwise they get: "No supported browser found on Windows. Install Google Chrome or Microsoft Edge, then retry."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.