Conversation
|
|
||
| build_spl: clean | ||
| python -m splunk_eventgen build --destination ./ | ||
|
|
There was a problem hiding this comment.
make lint will only lint the newly added and changed parts of python files here.
| @flake8 $(NEWLY_ADDED_PY_FILES) || true | ||
| endif | ||
| @git diff -U0 -- '*.py' | flake8 --diff || true | ||
|
|
There was a problem hiding this comment.
make format will only format newly added python files and sort imports for both newly added and changed python files.
| description-file = README.md | ||
| version-from-file: __init__.py | ||
|
|
||
| [yapf] |
There was a problem hiding this comment.
yapf style is based on pep8 here.
|
@li-wu Will you be including linted code changes to this PR? |
|
@arctan5x , not really. This PR will not include the formatting changes for existing Python code. You can see that the command |
|
@li-wu If you want to introduce linting, I would recommend applying a linter to the codebase all together after the tests cases are added. |
Totally agree! |
GordonWang
left a comment
GordonWang
left a comment
There was a problem hiding this comment.
I agree with you all.
Let's format all the code after adding the unit test cases. In case there is any bug in the formatting tool which may introduce regression after formatting all the code.
3 participants
No description provided.