This repository was archived by the owner on Sep 26, 2025. It is now read-only.
SII-4119: Stop Kubernetes nodes from showing up as the address used to connect to Kubelet #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o connect to Kubelet * Add kubelet_address as an alternative address to use to connect to Kubelet in place of node_name. - This relates to ADDON-21681
Contributor
|
Why do you need another configurable parameter for kubelet_address ? Just reuse node_name if possible. Does it mean something else in your implementation? Need more context. |
Author
If you look at the other linked issue, we tried reusing node_name at first. However, this came with the unfortunate side-effect of setting the node_name to the IP address in the metrics data that came through. Where there used to be a single variable, we need two separate variables now: one to describe the node in metrics and one used for the connection itself. |
Contributor
|
Cool. Thanks :) |
- As per cphalak's PR comment, this should be the default case for all users.
chaitanyaphalak
approved these changes
Jun 5, 2019
chaitanyaphalak
approved these changes
Jun 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the following PR in splunk-connect-for-kubernetes: [1]
[1] splunk/splunk-connect-for-kubernetes#137