This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Added more robust conditions to handle missing metrics #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtregonning
suggested changes
Jul 19, 2019
Contributor
dtregonning
left a comment
dtregonning
left a comment
There was a problem hiding this comment.
Clean up extra spaces and make sure that a metric missing time, cant have proceding metrics names and values
|
|
||
| def emit_uptime(tag:, start_time:, labels:) | ||
| uptime = @scraped_at - Time.iso8601(start_time) | ||
| uptime = @scraped_at - Time.iso8601(start_time) unless start_time.nil? |
Contributor
There was a problem hiding this comment.
please remove extra space
| emit_cpu_metrics tag: tag, metrics: container['cpu'], labels: labels | ||
| emit_memory_metrics tag: tag, metrics: container['memory'], labels: labels | ||
| emit_uptime tag: tag, start_time: container['startTime'], labels: labels unless container['startTime'].nil? | ||
| emit_cpu_metrics tag: tag, metrics: container['cpu'], labels: labels unless container['cpu'].nil? |
chaitanyaphalak
force-pushed
the
metrics-add-robust-error-handling
branch
from
08db1ce to
3f90dac
Compare
dtregonning
suggested changes
Jul 23, 2019
Contributor
dtregonning
left a comment
dtregonning
left a comment
There was a problem hiding this comment.
Thanks for the updates CP.
Can you add unit tests for metrics not containing time to show behavior of connector handling missing time fields
chaitanyaphalak
force-pushed
the
metrics-add-robust-error-handling
branch
2 times, most recently
from
acf758d to
679466c
Compare
chaitanyaphalak
force-pushed
the
metrics-add-robust-error-handling
branch
from
679466c to
174b4fa
Compare
dtregonning
approved these changes
Jul 25, 2019
Contributor
dtregonning
left a comment
dtregonning
left a comment
There was a problem hiding this comment.
Thank You for adding tests - merge when ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.