ESCU 6 Unit Testing Facilitation Branch#4096
Draft
pyth0n1c wants to merge 35 commits into
Draft
Conversation
…could not be git moved AND updated in the same operation because git instead interpreted this as deleting the old file and creating a new one. To preserve git history, the files have been moved in this commit and will be updated in the next commit.
…entionally moved, but not updated, have now been updated with the new format.
…t missing from here - notably content which has a MANUAL_REVIEW flag. This content does not parse until it has been updated, which means it could not be compiled into the schemas. These files will be updated when all content in the repo successfully parses.
…ged since the pr was first opened
Co-authored-by: Nasreddine Bencherchali <nasreddineb@splunk.com>
…tions in playbooks that were previously unvalidated. Add a MANUAL_REVIEW section, which is commented out, for clarity and to allow CICD to run and pass on this content. Renamed an existing playbook because it diverges from the name of that playbook elsewhere.
Port playbooks
ESCU 6 Manual Migrations
pyth0n1c
added
ESCU 6
and removed
Detections
Lookups
Macros
Datasource
Playbooks
Baselines
labels
github-actions
Bot
added
Detections
Lookups
Macros
Datasource
Playbooks
Baselines
labels
remove the rba_upgrade_tracking.json file and update the default.xml file to avoid conflict around multiple definitions of this file.
bump pulled AWS TA version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS PR
This PR should not be merged.
It only exists to facilitate unit testing of ESCU 6 content.
Due to the way that the unit_testing workflow functions, it requires that workflow changes be present both in a PR's source branch as well as the target branch of that PR.
This is why the
escu_6PR, currently targeted againstdevelop, is expected to fail unit-testing - those unit-testing workflow updates do not (yet) exist in thedevelopbranch: #4082This PR exists as an intermediary so that unit-testing can run on changed content before the
developbranch has been updated.When it is time to merge the
escu_6PR todevelop, this branch should simply be closed out.