Skip to content

fix: fixed issue with Azure AD audit input creation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: fixed issue with Azure AD audit input creation #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Version 4.0.1
# Version 4.0.2
* Bug fix - Problem creating new AAD Audit Input - [Issue #3](https://github.com/splunk/splunk-add-on-microsoft-azure/issues/3)
* Bug fix - Azure AD User and Group pagination issue

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This add-on is built with Splunk's [UCC Generator](https://github.com/splunk/add

Example:

ucc-gen --ta-version=4.0.1
ucc-gen --ta-version=4.0.2

The add-on will be built in an `output` directory in the root of the repository.

Expand Down
7 changes: 4 additions & 3 deletions globalConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"meta": {
"name": "TA-MS-AAD",
"displayName": "Splunk Add-on for Microsoft Azure",
"version": "4.0.1",
"version": "4.0.2",
"apiVersion": "3.0.0",
"restRoot": "TA_MS_AAD",
"schemaVersion": "0.0.3"
Expand Down Expand Up @@ -1028,14 +1028,15 @@
"entity": [
{
"type": "helpLink",
"field": "AAD_sign_in_note",
"field": "AAD_audit_note",
"label": "",
"help": "This input uses Microsoft Graph Azure AD activity reports and is subject to throttling limits. Refer to the documentation link above for more information.",
"tooltip": "Azure AD throttling guidance",
"options": {
"text": "Azure AD throttling guidance",
"link": "https://github.com/splunk/splunk-add-on-microsoft-azure/wiki/Configure-Azure-Active-Directory-inputs-for-the-Splunk-Add-on-for-Microsoft-Azure#throttling-guidance"
}
},
"required": false
},
{
"field": "name",
Expand Down
2 changes: 1 addition & 1 deletion package/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": {
"group": null,
"name": "TA-MS-AAD",
"version": "4.0.1"
"version": "4.0.2"
},
"author": [
{
Expand Down
4 changes: 4 additions & 0 deletions package/bin/MS_AAD_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ def get_scheme(self):
scheme.add_argument(smi.Argument("name", title="Name",
description="",
required_on_create=True))
scheme.add_argument(smi.Argument("AAD_audit_note", title="",
description="Azure AD throttling guidance https://splunkbase.splunk.com/app/3757/#/details#throttling-guidance",
required_on_create=False,
required_on_edit=False))
scheme.add_argument(smi.Argument("azure_app_account", title="Azure App Account",
description="",
required_on_create=True,
Expand Down
2 changes: 1 addition & 1 deletion package/bin/MS_AAD_signins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def get_scheme(self):
scheme.add_argument(smi.Argument("name", title="Name",
description="",
required_on_create=True))
scheme.add_argument(smi.Argument("AAD_sign_in_note", title=" Date",
scheme.add_argument(smi.Argument("AAD_sign_in_note", title="",
description="Azure AD throttling guidance https://splunkbase.splunk.com/app/3757/#/details#throttling-guidance",
required_on_create=False,
required_on_edit=False))
Expand Down