CSPL-4281 Fix MC crash loop during scale-down #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmediately Monitoring Console crashed when resources scaled down because peer config update was gated by phase == PhaseReady check. During scale operations, phase changes and update was skipped, leaving MC trying to connect to deleted pods. Fix: Move ApplyMonitoringConsoleEnvConfigMap() outside phase check in all reconcilers to update peer list immediately after StatefulSet changes. Affected: ApplyStandalone, ApplyClusterManager, ApplyClusterMaster, ApplyLicenseManager, ApplyLicenseMaster, ApplySearchHeadCluster
Collaborator
Pull Request Test Coverage Report for Build 19736798702Details
💛 - Coveralls |
Collaborator
Pull Request Test Coverage Report for Build 19759679833Details
💛 - Coveralls |
kubabuczak
changed the title
kubabuczak
force-pushed
the
CSPL-4281-fix-stale-peer-cm-config
branch
from
f588c3a to
f3da616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes MC crash loop during scale-down. MC ConfigMap update was gated by
phase == PhaseReadycheck, causing peer config to not update when resources scaled down. MC kept trying to connect to deleted pods, resulting in continuous restarts.Key Changes
Moved ApplyMonitoringConsoleEnvConfigMap() outside phase check in:
standalone.goclustermanager.go/clustermaster.gosearchheadcluster.golicensemanager.go/licensemaster.goConfigMap now updates immediately after StatefulSet changes, keeping peer list synchronized.
Testing and Verification
Automated: Existing managermc1 test validates MC ConfigMap and Ready state
Related Issues
JIRA: CSPL-4281 - MC crashes on Standalone scale-down
PR Checklist