Add sqs_smartubus_cp to providers#1716
Merged
kasiakoziol merged 2 commits intodevelopfrom Feb 24, 2026
Merged
Conversation
5 tasks
Collaborator
Pull Request Test Coverage Report for Build 22311893744Details
💛 - Coveralls |
Collaborator
Pull Request Test Coverage Report for Build 22296661323Details
💛 - Coveralls |
Collaborator
vivekr-splunk
left a comment
There was a problem hiding this comment.
the value sqs_cp and sqs_smartstore_cp is confusing should we have similar name both the places
| // +kubebuilder:validation:XValidation:rule="self.sqs.dlq == oldSelf.sqs.dlq",message="sqs.dlq is immutable once created" | ||
| // +kubebuilder:validation:XValidation:rule="self.sqs.endpoint == oldSelf.sqs.endpoint",message="sqs.endpoint is immutable once created" | ||
| // +kubebuilder:validation:XValidation:rule="self.provider != 'sqs' || has(self.sqs)",message="sqs must be provided when provider is sqs" | ||
| // +kubebuilder:validation:XValidation:rule="(self.provider != 'sqs' && self.provider != 'sqs_cp') || has(self.sqs)",message="sqs must be provided when provider is sqs or sqs_cp" |
Collaborator
There was a problem hiding this comment.
I am unsure sqs_cp is a provider. what is sqs_cp?
Collaborator
Author
There was a problem hiding this comment.
Responded to you in a private message
| osProvider := "" | ||
| if os.Provider == "s3" { | ||
| osProvider = "sqs_smartbus" | ||
| if queueProvider == "sqs_smartbus" { |
Collaborator
There was a problem hiding this comment.
am assuming that the defaults always sets sqs_smartbus or sqs_smartbus_cp without leaving this blank, if left blank this can silently misconfigures the configuration
Collaborator
Author
There was a problem hiding this comment.
Responded to Raizel about it above. We have a spec validation that doesn't allow any other values, so it is always either sqs_smartbus or sqs_smartbus_cp.
rlieberman-splunk
approved these changes
Feb 23, 2026
vivekr-splunk
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds sqs_cp providers to allowed providers for Queue
Key Changes
Testing and Verification
Automated and manual tests
Related Issues
PR Checklist