Skip to content

Add sqs_smartubus_cp to providers#1716

Merged
kasiakoziol merged 2 commits intodevelopfrom
feature/add-sqs-smartbus-cp-provider
Feb 24, 2026
Merged

Add sqs_smartubus_cp to providers#1716
kasiakoziol merged 2 commits intodevelopfrom
feature/add-sqs-smartbus-cp-provider

Conversation

@kasiakoziol
Copy link
Collaborator

@kasiakoziol kasiakoziol commented Feb 23, 2026

Description

Adds sqs_cp providers to allowed providers for Queue

Key Changes

  • sqs_cp added to allowed providers for Queue
  • code adjusted to support new provider

Testing and Verification

Automated and manual tests

Related Issues

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Feb 23, 2026

Pull Request Test Coverage Report for Build 22311893744

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/indexercluster_controller.go 0 1 0.0%
internal/controller/ingestorcluster_controller.go 0 1 0.0%
Totals Coverage Status
Change from base Build 22234080702: 0.02%
Covered Lines: 11836
Relevant Lines: 14101

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22296661323

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/indexercluster_controller.go 0 1 0.0%
internal/controller/ingestorcluster_controller.go 0 1 0.0%
Totals Coverage Status
Change from base Build 22234080702: 0.03%
Covered Lines: 11837
Relevant Lines: 14101

💛 - Coveralls

Copy link
Collaborator

@vivekr-splunk vivekr-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value sqs_cp and sqs_smartstore_cp is confusing should we have similar name both the places

// +kubebuilder:validation:XValidation:rule="self.sqs.dlq == oldSelf.sqs.dlq",message="sqs.dlq is immutable once created"
// +kubebuilder:validation:XValidation:rule="self.sqs.endpoint == oldSelf.sqs.endpoint",message="sqs.endpoint is immutable once created"
// +kubebuilder:validation:XValidation:rule="self.provider != 'sqs' || has(self.sqs)",message="sqs must be provided when provider is sqs"
// +kubebuilder:validation:XValidation:rule="(self.provider != 'sqs' && self.provider != 'sqs_cp') || has(self.sqs)",message="sqs must be provided when provider is sqs or sqs_cp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure sqs_cp is a provider. what is sqs_cp?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to you in a private message

osProvider := ""
if os.Provider == "s3" {
osProvider = "sqs_smartbus"
if queueProvider == "sqs_smartbus" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am assuming that the defaults always sets sqs_smartbus or sqs_smartbus_cp without leaving this blank, if left blank this can silently misconfigures the configuration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to Raizel about it above. We have a spec validation that doesn't allow any other values, so it is always either sqs_smartbus or sqs_smartbus_cp.

@kasiakoziol kasiakoziol merged commit 528ac31 into develop Feb 24, 2026
63 of 80 checks passed
@kasiakoziol kasiakoziol deleted the feature/add-sqs-smartbus-cp-provider branch February 24, 2026 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants