Skip to content

Fix app_tel_for_sok app.conf install stanza header#1724

Merged
vivekr-splunk merged 3 commits intosplunk:developfrom
mmarod:fix/telemetry-app-install-stanza-header
Feb 26, 2026
Merged

Fix app_tel_for_sok app.conf install stanza header#1724
vivekr-splunk merged 3 commits intosplunk:developfrom
mmarod:fix/telemetry-app-install-stanza-header

Conversation

@mmarod
Copy link

@mmarod mmarod commented Feb 25, 2026

Description

Fixes #1723

Key Changes

Fixes the first line of the app.conf within app_tel_for_sok so it does not have a -e prefix.

Testing and Verification

Locally built the operator and confirmed that app.conf is correct.

splunk@splunk-ingestor-ingestor-0:/opt/splunk$ cat /opt/splunk/etc/apps/app_tel_for_sok/default/app.conf
[install]
is_configured = 1

[ui]
is_visible = 0
label = Splunk Operator for K8s

[launcher]
author = Splunk
description = When telemetry is enabled, this app is used to help Splunk understand how many customers are deploying Splunk using Splunk Operator for K8s
version = 1.0.0

Related Issues

Jira tickets, GitHub issues, Support tickets...

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@mmarod mmarod changed the base branch from main to develop February 25, 2026 18:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the invalid app.conf generated for the telemetry app (app_tel_for_sok) by avoiding echo -e, which can be emitted literally as -e on some /bin/sh implementations.

Changes:

  • Replace echo -e with printf '%s' when writing default/app.conf and metadata/default.meta for the telemetry app.
  • Keep the rest of the telemetry app creation flow unchanged (directory creation + reload/bundle push).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mmarod
Copy link
Author

mmarod commented Feb 25, 2026

recheck

@vivekr-splunk
Copy link
Collaborator

I have read the CLA Document and I hereby sign the CLA

@vivekr-splunk
Copy link
Collaborator

I have read the Code of Conduct and I hereby sign the COC

1 similar comment
@mmarod
Copy link
Author

mmarod commented Feb 25, 2026

I have read the Code of Conduct and I hereby sign the COC

@mmarod
Copy link
Author

mmarod commented Feb 25, 2026

I have read the CLA Document and I hereby sign the CLA

@mmarod
Copy link
Author

mmarod commented Feb 25, 2026

I have read the Code of Conduct and I hereby accept the Terms

@mmarod mmarod force-pushed the fix/telemetry-app-install-stanza-header branch from 33eacf7 to 9a51fa5 Compare February 25, 2026 19:24
mmarod and others added 2 commits February 25, 2026 21:11
…ll] on its first line instead of just [install]
…LS_TOKEN is not available in these workflow runs for GitHub security reasons)
@gabrielm-splunk gabrielm-splunk force-pushed the fix/telemetry-app-install-stanza-header branch from a720d63 to 05aadae Compare February 26, 2026 02:12
@vivekr-splunk vivekr-splunk merged commit 7fa8698 into splunk:develop Feb 26, 2026
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splunk Operator: app_tel_for_sok app.conf install stanza is invalid

6 participants