Remove MC from AWS Appframework Tests (Phase 1)#1868
Draft
gabrielm-splunk wants to merge 2 commits intodevelopfrom
Draft
Remove MC from AWS Appframework Tests (Phase 1)#1868gabrielm-splunk wants to merge 2 commits intodevelopfrom
gabrielm-splunk wants to merge 2 commits intodevelopfrom
Conversation
Removes unnecessary Monitoring Console deployments from AWS appframework test suite (s1, m4, c3). MC is not the test subject in these tests, just an incidental deployment adding 4-9 minutes overhead per test. Changes: - Remove MC deployment sections (S3 uploads, app framework specs) - Remove MonitoringConsoleRef from CR specs - Pass empty string for mcRef parameters in deployment functions - Remove MC verification calls (VerifyMonitoringConsoleReady) - Remove MC app source info from verification arrays - Remove MC pod arrays from verification logic - Update test comments to remove MC references - Fix variable scoping issues post-MC removal Files Modified: - test/appframework_aws/s1/appframework_aws_test.go (303 lines removed, 9 tests) - test/appframework_aws/m4/appframework_aws_test.go (209 lines removed, 15 tests) - test/appframework_aws/m4/manager_appframework_test.go (143 lines removed, 17 tests) - test/appframework_aws/c3/appframework_aws_test.go (141 lines removed, 2 tests) - test/appframework_aws/c3/manager_appframework_test.go (207 lines removed, 22 tests) Total: 1,049 lines removed (net), 65 tests modified, all files compile successfully. Expected impact: 2-3 hour reduction in AWS appframework test runtime (65 tests × 4-9 minutes per test = 260-585 minutes saved). Refs: /remove-mc-infrastructure skill, sok-testing-expert
Remove extra blank lines per go fmt standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary Monitoring Console deployments from AWS appframework tests (s1, m4, c3).
Motivation
MC is deployed in these tests but is not the test subject. Each MC deployment adds 4-9 minutes overhead per test. This PR removes MC from AWS appframework tests to improve test execution time.
Changes
Files Modified:
test/appframework_aws/s1/appframework_aws_test.go- 303 lines removed, 9 tests modifiedtest/appframework_aws/m4/appframework_aws_test.go- 209 lines removed, 15 tests modifiedtest/appframework_aws/m4/manager_appframework_test.go- 143 lines removed, 17 tests modifiedtest/appframework_aws/c3/appframework_aws_test.go- 141 lines removed, 2 tests modifiedtest/appframework_aws/c3/manager_appframework_test.go- 207 lines removed, 22 tests modifiedTotal: 1,049 lines removed (net), 65 tests modified
Specific Removals:
MonitoringConsoleReffrom CR specificationsVerifyMonitoringConsoleReady)Expected Impact
Time Savings: 2-3 hours per full AWS appframework test run
Resource Savings:
No Functionality Loss: MC is not being tested in these suites
Testing
✅ Compilation: All 5 files compile successfully with
ginkgo buildtest/appframework_aws/s1/s1.test- 35 MBtest/appframework_aws/m4/m4.test- 80 MBtest/appframework_aws/c3/c3.test- 120 MB⏳ CI Pipeline: GitHub Actions running (full test suite validation)
Related Work
/remove-mc-infrastructureskillChecklist
Notes
Previous MC removal attempts (PR #1864, #1865) were obsoleted by the PR #1788 refactor. This PR is based on fresh research of the post-refactor codebase.