Fix bug of Value.toDate(string value) is not thread safe.#109
Merged
shakeelmohamed merged 2 commits intosplunk:developfrom Aug 21, 2017
Merged
Conversation
…ing value) to static synchronized Date toDate(String value)
Contributor
Author
Contributor
Author
|
The reasons why
In general, there are three ways to solve this problem.
I prefer Option1 since it has minimal impact on the original code. In most cases we don't have multithreaded access so it won't cause thread context switch. |
Contributor
|
The build failure here is very strange, I've sent an email to Travis CI support |
Contributor
|
I've fixed some Travis CI configuration on the develop branch, merge it into your branch and the tests should run properly again |
…ate-is-not-thread-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug of Value.toDate(string value) is not thread safe.